linux.git/net/bridge, branch v2.6.21.7

[BRIDGE]: Unaligned access when comparing ethernet addresses

2007-04-17T21:16:00+00:00

compare_ether_addr() implicitly requires that the addresses
passed are 2-bytes aligned in memory.

This is not true for br_stp_change_bridge_id() and
br_stp_recalculate_bridge_id() in which one of the addresses
is unsigned char *, and thus may not be 2-bytes aligned.

Signed-off-by: Evgeny Kravtsunov 
Signed-off-by: Kirill Korotaev 
Signed-off-by: Pavel Emelianov

[NET]: fix up misplaced inlines.

2007-03-22T19:27:49+00:00

Turning up the warnings on gcc makes it emit warnings
about the placement of 'inline' in function declarations.
Here's everything that was under net/

Signed-off-by: Dave Jones 
Signed-off-by: David S. Miller

[BRIDGE]: Fix fdb RCU race

2007-03-22T19:25:20+00:00

br_fdb_get use atomic_inc to increase the refcount of an element found
on a RCU protected list, which can lead to the following race:

CPU0					CPU1

					br_fdb_get:   rcu_read_lock
					__br_fdb_get: find element
fdb_delete:   hlist_del_rcu
	      br_fdb_put
br_fdb_put:   atomic_dec_and_test
	      call_rcu(fdb_rcu_free)	br_fdb_get:   atomic_inc
						      rcu_read_unlock
fdb_rcu_free: kmem_cache_free

Use atomic_inc_not_zero instead.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[BRIDGE]: adding new device to bridge should enable if up

2007-03-08T00:10:53+00:00

One change introduced by the workqueue removal patch is that adding an
interface that is up to a bridge which is also up does not ever call
br_stp_enable_port(), leaving the port in DISABLED state until we do
ifconfig down and up or link events occur.

The following patch to the br_add_if function fixes it.
This is a regression introduced in 2.6.21.

Submitted-by: Aji_Srinivas@emc.com
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[BRIDGE]: Fix locking of set path cost.

2007-02-28T17:42:12+00:00

This change goes with earlier change to get rid of
work queue for path cost. Now stp_set_path_cost does its own
locking. This is to allow it to call br_path_cost() which calls
ethtool interfaces (might sleep).

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[BRIDGE]: eliminate workqueue for carrier check

2007-02-26T19:42:59+00:00

Having a work queue for checking carrier leads to lots of race issues.
Simpler to just get the cost when data structure is created and
update on change.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[BRIDGE]: get rid of miscdevice include

2007-02-26T19:42:58+00:00

The bridge hasn't used miscdevice for a long long time.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

[PATCH] Convert highest_possible_processor_id to nr_cpu_ids

2007-02-21T01:10:13+00:00

We frequently need the maximum number of possible processors in order to
allocate arrays for all processors.  So far this was done using
highest_possible_processor_id().  However, we do need the number of
processors not the highest id.  Moreover the number was so far dynamically
calculated on each invokation.  The number of possible processors does not
change when the system is running.  We can therefore calculate that number
once.

Signed-off-by: Christoph Lameter 
Cc: Frederik Deweerdt 
Cc: Neil Brown 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] sysctl: remove insert_at_head from register_sysctl

2007-02-14T16:09:59+00:00

The semantic effect of insert_at_head is that it would allow new registered
sysctl entries to override existing sysctl entries of the same name.  Which is
pain for caching and the proc interface never implemented.

I have done an audit and discovered that none of the current users of
register_sysctl care as (excpet for directories) they do not register
duplicate sysctl entries.

So this patch simply removes the support for overriding existing entries in
the sys_sysctl interface since no one uses it or cares and it makes future
enhancments harder.

Signed-off-by: Eric W. Biederman 
Acked-by: Ralf Baechle 
Acked-by: Martin Schwidefsky 
Cc: Russell King 
Cc: David Howells 
Cc: "Luck, Tony" 
Cc: Ralf Baechle 
Cc: Paul Mackerras 
Cc: Martin Schwidefsky 
Cc: Andi Kleen 
Cc: Jens Axboe 
Cc: Corey Minyard 
Cc: Neil Brown 
Cc: "John W. Linville" 
Cc: James Bottomley 
Cc: Jan Kara 
Cc: Trond Myklebust 
Cc: Mark Fasheh 
Cc: David Chinner 
Cc: "David S. Miller" 
Cc: Patrick McHardy 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] remove many unneeded #includes of sched.h

2007-02-14T16:09:54+00:00

After Al Viro (finally) succeeded in removing the sched.h #include in module.h
recently, it makes sense again to remove other superfluous sched.h includes.
There are quite a lot of files which include it but don't actually need
anything defined in there.  Presumably these includes were once needed for
macros that used to live in sched.h, but moved to other header files in the
course of cleaning it up.

To ease the pain, this time I did not fiddle with any header files and only
removed #includes from .c-files, which tend to cause less trouble.

Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
configs in arch/arm/configs on arm.  I also checked that no new warnings were
introduced by the patch (actually, some warnings are removed that were emitted
by unnecessarily included header files).

Signed-off-by: Tim Schmielau 
Acked-by: Russell King 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds