linux.git/net/core/dev.c, branch v2.6.23

[NET]: Share correct feature code between bridging and bonding

2007-08-14T05:52:14+00:00

http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the
bonding driver may produce bogus combinations of the checksum
flags and SG/TSO.

For example, if you bond devices with NETIF_F_HW_CSUM and
NETIF_F_IP_CSUM you'll end up with a bonding device that
has neither flag set.  If both have TSO then this produces
an illegal combination.

The bridge device on the other hand has the correct code to
deal with this.

In fact, the same code can be used for both.  So this patch
moves that logic into net/core/dev.c and uses it for both
bonding and bridging.

In the process I've made small adjustments such as only
setting GSO_ROBUST if at least one constituent device
supports it.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[NET]: Allow netdev REGISTER/CHANGENAME events to fail

2007-07-31T09:28:15+00:00

This patch adds code to allow errors to be passed up from event
handlers of NETDEV_REGISTER and NETDEV_CHANGENAME.  It also adds
the notifier_from_errno/notifier_to_errnor helpers to pass the
errno value up to the notifier caller.

If an error is detected when a device is registered, it causes
that operation to fail.  A NETDEV_UNREGISTER will be sent to
all event handlers.

Similarly if NETDEV_CHANGENAME fails the original name is restored
and a new NETDEV_CHANGENAME event is sent.

As such all event handlers must be idempotent with respect to
these events.

When an event handler is registered NETDEV_REGISTER events are
sent for all devices currently registered.  Should any of them
fail, we will send NETDEV_GOING_DOWN/NETDEV_DOWN/NETDEV_UNREGISTER
events to that handler for the devices which have already been
registered with it.  The handler registration itself will fail.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[NET]: Take dev_base_lock when moving device name hash list entry

2007-07-31T09:28:13+00:00

When we added name-based hashing the dev_base_lock was designated as the
lock to take when changing the name hash list.  Unfortunately, because
it was a preexisting lock that just happened to be taken in the right
spots we neglected to take it in dev_change_name.

The race can affect calles of __dev_get_by_name that do so without taking
the RTNL.  They may end up walking down the wrong hash chain and end up
missing the device that they're looking for.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[NET]: Call uninit if necessary in register_netdevice

2007-07-31T09:28:12+00:00

This patch makes register_netdevice call dev->uninit if the regsitration
fails after dev->init has completed successfully.  Very few drivers use
the init/uninit calls but at least one (drivers/net/wan/sealevel.c) may
leak without this change.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[NET]: kernel-doc fixes

2007-07-31T09:28:00+00:00

Fix kernel-doc omissions in net/:

Warning(linux-2.6.23-rc1//net/core/dev.c:2728): No description found for parameter 'addr'
Warning(linux-2.6.23-rc1//net/core/dev.c:2752): No description found for parameter 'addr'
Warning(linux-2.6.23-rc1//net/core/dev.c:3839): No description found for parameter 'net_dma'
Warning(linux-2.6.23-rc1//net/core/dev.c:3877): No description found for parameter 'state'

Signed-off-by: Randy Dunlap 
Signed-off-by: David S. Miller

[NET]: Fix loopback crashes when multiqueue is enabled.

2007-07-21T02:45:45+00:00

From: Patrick McHardy 

Signed-off-by: David S. Miller

[NET] CORE: Fix whitespace errors.

2007-07-19T01:43:23+00:00

Signed-off-by: YOSHIFUJI Hideaki

[NET]: move __dev_addr_discard adjacent to dev_addr_discard for readability

2007-07-18T09:12:56+00:00

Signed-off-by: Denis Cheng 
Signed-off-by: David S. Miller

[NET]: merge dev_unicast_discard and dev_mc_discard into one

2007-07-18T09:12:03+00:00

this two functions could share the dev->_xmit_lock acquired context.

Signed-off-by: Denis Cheng 
Signed-off-by: David S. Miller

[NET]: move dev_mc_discard from dev_mcast.c to dev.c

2007-07-18T09:10:54+00:00

Because this function is only called by unregister_netdevice,
this moving could make this non-global function static,
and also remove its declaration in netdevice.h;

Any further, function __dev_addr_discard is also just called by
dev_mc_discard and dev_unicast_discard, keeping this two functions
both in one c file could make __dev_addr_discard also static
and remove its declaration in netdevice.h;

Futhermore, the sequential call to dev_unicast_discard and then
dev_mc_discard in unregister_netdevice have a similar mechanism that:
(netif_tx_lock_bh / __dev_addr_discard / netif_tx_unlock_bh),
they should merged into one to eliminate duplicates in acquiring and
releasing the dev->_xmit_lock, this would be done in my following patch.

Signed-off-by: Denis Cheng 
Signed-off-by: David S. Miller