linux.git/net/core/flow_dissector.c, branch v4.3

flow_dissector: Use 'const' where possible.

2015-09-02T04:19:17+00:00

Signed-off-by: David S. Miller

flow: Move __get_hash_from_flowi{4,6} into flow_dissector.c

2015-09-02T00:00:24+00:00

These cannot live in net/core/flow.c which only builds when XFRM is
enabled.

Reported-by: kbuild test robot 
Signed-off-by: David S. Miller

flow_dissector: Don't use bit fields.

2015-09-01T23:46:08+00:00

Just have a flags member instead.

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from net/core/flow_dissector.c:1:
   In function 'flow_keys_hash_start',
       inlined from 'flow_hash_from_keys' at net/core/flow_dissector.c:553:34:
>> include/linux/compiler.h:447:38: error: call to '__compiletime_assert_459' declared with attribute error: BUILD_BUG_ON failed: FLOW_KEYS_HASH_OFFSET % sizeof(u32)

Reported-by: kbuild test robot 
Signed-off-by: David S. Miller

flow_dissector: Ignore flow dissector return value from ___skb_get_hash

2015-09-01T22:06:23+00:00

In ___skb_get_hash ignore return value from skb_flow_dissect_flow_keys.
A failure in that function likely means that there was a parse error,
so we may as well use whatever fields were found before the error was
hit.  This is also good because it means we won't keep trying to derive
the hash on subsequent calls to skb_get_hash for the same packet.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

flow_dissector: Add control/reporting of encapsulation

2015-09-01T22:06:23+00:00

Add an input flag to flow dissector on rather dissection should stop
when encapsulation is detected (IP/IP or GRE). Also, add a key_control
flag that indicates encapsulation was encountered during the
dissection.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

flow_dissector: Add flag to stop parsing when an IPv6 flow label is seen

2015-09-01T22:06:23+00:00

Add an input flag to flow dissector on rather dissection should be
stopped when a flow label is encountered. Presumably, the flow label
is derived from a sufficient hash of an inner transport packet so
further dissection is not needed (that is ports are not included in
the flow hash). Using the flow label instead of ports has the additional
benefit that packet fragments should hash to same value as non-fragments
for a flow (assuming that the same flow label is used).

We set this flag by default in for skb_get_hash.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

flow_dissector: Add flag to stop parsing at L3

2015-09-01T22:06:23+00:00

Add an input flag to flow dissector on rather dissection should be
stopped when an L3 packet is encountered. This would be useful if a
caller just wanted to get IP addresses of the outermost header (e.g.
to do an L3 hash).

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

flow_dissector: Support IPv6 fragment header

2015-09-01T22:06:22+00:00

Parse NEXTHDR_FRAGMENT. When seen account for it in the fragment bits of
key_control. Also, check if first fragment should be parsed.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

flow_dissector: Add control/reporting of fragmentation

2015-09-01T22:06:22+00:00

Add an input flag to flow dissector on rather dissection should be
attempted on a first fragment. Also add key_control flags to indicate
that a packet is a fragment or first fragment.

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller

flow_dissector: Add flags argument to skb_flow_dissector functions

2015-09-01T22:06:22+00:00

The flags argument will allow control of the dissection process (for
instance whether to parse beyond L3).

Signed-off-by: Tom Herbert 
Signed-off-by: David S. Miller