linux.git/net/mac802154/tx.c, branch v4.3

mac802154: Fix memory corruption with global deferred transmit state.

2015-07-30T12:08:55+00:00

When transmitting a packet via a mac802154 driver that can sleep in
its transmit function, mac802154 defers the call to the driver's
transmit function to a per-device workqueue.

However, mac802154 uses a single global work_struct for this, which
means that if you have more than one registered mac802154 interface
in the system, and you transmit on more than one of them at the same
time, you'll very easily cause memory corruption.

This patch moves the deferred transmit processing state from global
variables to struct ieee802154_local, and this seems to fix the memory
corruption issue.

Signed-off-by: Lennert Buytenhek 
Acked-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: add interframe spacing time handling

2014-11-13T03:51:58+00:00

This patch adds a new interframe spacing time handling into mac802154
layer. Interframe spacing time is a time period between each transmit.
This patch adds a high resolution timer into mac802154 and starts on
xmit complete with corresponding interframe spacing expire time if
ifs_handling is true. We make it variable because it depends if
interframe spacing time is handled by transceiver or mac802154. At the
timer complete function we wake the netdev queue again. This avoids
new frame transmit in range of interframe spacing time.

For synced driver we add no handling of interframe spacing time. This
is currently a lack of support in all synced xmit drivers. I suppose
it's working because the latency of workqueue which is needed to call
spi_sync.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: separate omit tx/rx flags

2014-10-29T22:07:45+00:00

This patch splits the IEEE802154_HW_OMIT_CKSUM hardware flag into
IEEE802154_HW_TX_OMIT_CKSUM and IEEE802154_HW_RX_OMIT_CKSUM. This is
useful to deliver the received crc from the driver layer to the monitor
interface. At the moment we can't do that without change the xmit
handling.

The received checksum should be visible in monitor mode only.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: use driver-ops function wrappers

2014-10-28T22:19:07+00:00

This patch replaces all directly called driver ops by previous
introduced driver-ops function wrappers.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: tx: remove monitor receive while xmit

2014-10-27T17:07:42+00:00

This removes the call of monitor receive funktion when any interface
type call xmit. There exist no such use case that a monitor interface
should receive the actual sending frame. One use case could be that a
wpan interface and monitor interface could be running at the same time
on one phy. Then the monitor interface receives the wpan frames also.
Furthermore we adding support for promiscous mode setting. With
promiscous mode setting we can't run a wpan and monitor interface at the
same time.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: tx: use put_unaligned_le16 for copy crc

2014-10-27T17:07:36+00:00

This patch replaces the memcpy with a put_unaligned_le16. The placement
of crc inside of PSDU can also be unaligned. With memcpy this can fail
on some architectures.

Signed-off-by: Alexander Aring 
Reported-by: Marcel Holtmann 
Signed-off-by: Marcel Holtmann

mac802154: tx: make worker information static

2014-10-26T18:18:35+00:00

This patch moves the worker information struct out of skb control block.
Instead control block we declare it static inside of tx.c file. We can do
that, because the worker can't be used twice at the same time. It's
protected by stop and wake netdev queue.

This patch fix an issue that the "struct ieee802154_xmit_cb" doesn't fit
into the skb control block on some kernel configuartion reported by
kbuild test robot.

It was introduced by commit fe24371d6645b766c59ec664c59d0a9c310ad455
("mac802154: tx: remove kmalloc in xmit hotpath").

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: tx: change naming convention

2014-10-26T16:24:05+00:00

This patch changes the naming convention of the tx functions like
mac80211. Just with an 802154 instead 80211 inside the name.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: tx: move stats tx increment

2014-10-26T16:24:05+00:00

This patch moves the stats increment of successful transmitted packets
in the right place when the skb was really successful transmitted.

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann

mac802154: tx: cleanup crc calculation

2014-10-26T16:24:05+00:00

Signed-off-by: Alexander Aring 
Signed-off-by: Marcel Holtmann