linux.git/net/sunrpc/addr.c, branch v5.13.4

net: sunrpc: interpret the return value of kstrtou32 correctly

2021-01-10T18:32:51+00:00

A return value of 0 means success. This is documented in lib/kstrtox.c.

This was found by trying to mount an NFS share from a link-local IPv6
address with the interface specified by its index:

  mount("[fe80::1%1]:/srv/nfs", "/mnt", "nfs", 0, "nolock,addr=fe80::1%1")

Before this commit this failed with EINVAL and also caused the following
message in dmesg:

  [...] NFS: bad IP address specified: addr=fe80::1%1

The syscall using the same address based on the interface name instead
of its index succeeds.

Credits for this patch go to my colleague Christian Speich, who traced
the origin of this bug to this line of code.

Signed-off-by: Johannes Nixdorf 
Fixes: 00cfaa943ec3 ("replace strict_strto calls")
Signed-off-by: Trond Myklebust

net: sunrpc: Fix off-by-one issues in 'rpc_ntop6'

2020-05-27T14:08:26+00:00

Fix off-by-one issues in 'rpc_ntop6':
 - 'snprintf' returns the number of characters which would have been
   written if enough space had been available, excluding the terminating
   null byte. Thus, a return value of 'sizeof(scopebuf)' means that the
   last character was dropped.
 - 'strcat' adds a terminating null byte to the string, thus if len ==
   buflen, the null byte is written past the end of the buffer.

Signed-off-by: Fedor Tokarev 
Signed-off-by: Anna Schumaker

SUNRPC: Use kmemdup_nul() in rpc_parse_scope_id()

2020-02-03T21:35:07+00:00

Using kmemdup_nul() is more efficient when the length is known.

Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

treewide: Add SPDX license identifier for missed files

2019-05-21T08:50:45+00:00

Add SPDX license identifiers to all files which:

 - Have no license information of any form

 - Have EXPORT_.*_SYMBOL_GPL inside which was used in the
   initial scan/conversion to ignore the file

These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:

  GPL-2.0-only

Signed-off-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman

replace strict_strto calls

2014-07-12T22:45:49+00:00

Replace obsolete strict_strto calls with appropriate kstrto calls

Signed-off-by: Daniel Walter 
Signed-off-by: Trond Myklebust

sunrpc: move address copy/cmp/convert routines and prototypes from clnt.h to addr.h

2013-02-05T14:41:14+00:00

These routines are used by server and client code, so having them in a
separate header would be best.

Signed-off-by: Jeff Layton 
Acked-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

SUNRPC: parametrize rpc_uaddr2sockaddr() by network context

2012-02-01T00:28:12+00:00

Parametrize rpc_uaddr2sockaddr() by network context and thus force it's callers to pass
in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: parametrize rpc_pton() by network context

2012-02-01T00:28:12+00:00

Parametrize rpc_pton() by network context and thus force it's callers to pass
in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: parametrize rpc_pton6() by network context

2012-02-01T00:28:11+00:00

Parametrize rpc_pton6() by network context and thus force it's caller
to pass in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

SUNRPC: parametrize rpc_parse_scope_id() by network context

2012-02-01T00:28:11+00:00

Parametrize rpc_parse_scope_id() by network context and thus force it's caller
to pass in network context instead of using hard-coded "init_net".

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust