linux.git/net/wireless/sme.c, branch v3.15

cfg80211: free sme on connection failures

2014-05-05T12:59:00+00:00

cfg80211 is notified about connection failures by
__cfg80211_connect_result() call. However, this
function currently does not free cfg80211 sme.

This results in hanging connection attempts in some cases

e.g. when mac80211 authentication attempt is denied,
we have this function call:
ieee80211_rx_mgmt_auth() -> cfg80211_rx_mlme_mgmt() ->
cfg80211_process_auth() -> cfg80211_sme_rx_auth() ->
__cfg80211_connect_result()

but cfg80211_sme_free() is never get called.

Fixes: ceca7b712 ("cfg80211: separate internal SME implementation")
Cc: stable@vger.kernel.org (3.10+)
Signed-off-by: Eliad Peller 
Signed-off-by: Johannes Berg

cfg80211: remove macro ASSERT_RDEV_LOCK(rdev)

2014-03-19T20:29:58+00:00

Macro ASSERT_RDEV_LOCK(rdev) is equal to ASSERT_RTNL(), so replace it
with ASSERT_RTNL() and remove it.

Signed-off-by: Zhao, Gang 
Signed-off-by: Johannes Berg

cfg80211: send scan results from work queue

2014-02-06T08:55:19+00:00

Due to the previous commit, when a scan finishes, it is in theory
possible to hit the following sequence:
 1. interface starts being removed
 2. scan is cancelled by driver and cfg80211 is notified
 3. scan done work is scheduled
 4. interface is removed completely, rdev->scan_req is freed,
    event sent to userspace but scan done work remains pending
 5. new scan is requested on another virtual interface
 6. scan done work runs, freeing the still-running scan

To fix this situation, hang on to the scan done message and block
new scans while that is the case, and only send the message from
the work function, regardless of whether the scan_req is already
freed from interface removal. This makes step 5 above impossible
and changes step 6 to be
 5. scan done work runs, sending the scan done message

As this can't work for wext, so we send the message immediately,
but this shouldn't be an issue since we still return -EBUSY.

Signed-off-by: Johannes Berg

Merge branch 'for-john' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next

2014-01-13T19:40:59+00:00

cfg80211: Add a function to get the number of supported channels

2014-01-09T13:24:24+00:00

Add a utility function to get the number of channels supported by
the device, and update the places in the code that need this data.

Signed-off-by: Ilan Peer 
[replace another occurrence in libertas, fix kernel-doc, fix bugs]
Signed-off-by: Johannes Berg

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless

2014-01-06T19:08:41+00:00

cfg80211: Add support for QoS mapping

2013-12-19T15:29:22+00:00

This allows QoS mapping from external networks to be implemented as
defined in IEEE Std 802.11-2012, 10.24.9. APs can use this to advertise
DSCP ranges and exceptions for mapping frames to a specific UP over
Wi-Fi.

The payload of the QoS Map Set element (IEEE Std 802.11-2012, 8.4.2.97)
is sent to the driver through the new NL80211_ATTR_QOS_MAP attribute to
configure the local behavior either on the AP (based on local
configuration) or on a station (based on information received from the
AP).

Signed-off-by: Kyeyoon Park 
Signed-off-by: Jouni Malinen 
Signed-off-by: Johannes Berg

cfg80211: fix WARN_ON for re-association to the expired BSS

2013-12-05T14:00:29+00:00

cfg80211 allows re-association in managed mode and if a user
wants to re-associate to the same AP network after the time
period of IEEE80211_SCAN_RESULT_EXPIRE, cfg80211 warns with
the following message on receiving the connect result event.

------------[ cut here ]------------
WARNING: CPU: 0 PID: 13984 at net/wireless/sme.c:658
         __cfg80211_connect_result+0x3a6/0x3e0 [cfg80211]()
Call Trace:
 [] dump_stack+0x46/0x58
 [] warn_slowpath_common+0x87/0xb0
 [] warn_slowpath_null+0x15/0x20
 [] __cfg80211_connect_result+0x3a6/0x3e0 [cfg80211]
 [] ? update_rq_clock+0x2b/0x50
 [] ? update_curr+0x1/0x160
 [] cfg80211_process_wdev_events+0xb2/0x1c0 [cfg80211]
 [] ? pick_next_task_fair+0x63/0x170
 [] cfg80211_process_rdev_events+0x38/0x90 [cfg80211]
 [] cfg80211_event_work+0x1d/0x30 [cfg80211]
 [] process_one_work+0x17f/0x420
 [] worker_thread+0x11a/0x370
 [] ? rescuer_thread+0x2f0/0x2f0
 [] kthread+0xbb/0xc0
 [] ? kthread_create_on_node+0x120/0x120
 [] ret_from_fork+0x7c/0xb0
 [] ? kthread_create_on_node+0x120/0x120
---[ end trace 61f3bddc9c4981f7 ]---

The reason is that, in connect result event cfg80211 unholds
the BSS to which the device is associated (and was held so
far). So, for the event with status successful, when cfg80211
wants to get that BSS from the device's BSS list it gets a
NULL BSS because the BSS has been expired and unheld already.

Fix it by reshuffling the code.

Signed-off-by: Ujjal Roy 
Signed-off-by: Johannes Berg

cfg80211: rename regulatory_hint_11d() to regulatory_hint_country_ie()

2013-10-09T07:37:57+00:00

It is incorrect to refer to this as 11d as 802.11d was just a
proposed amendment, 802.11d was merged to the standard so
use proper terminology.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Johannes Berg

cfg80211: don't request disconnect if not connected

2013-08-14T12:00:19+00:00

Neil Brown reports that with libertas, my recent cfg80211
SME changes in commit ceca7b7121795ef81bd598a240d53a92566
("cfg80211: separate internal SME implementation") broke
libertas suspend because it we now asked it to disconnect
while already disconnected.

The problematic change is in cfg80211_disconnect() as it
previously checked the SME state and now calls the driver
disconnect operation unconditionally.

Fix this by checking if there's a current_bss indicating
a connection, and do nothing if not.

Reported-and-tested-by: Neil Brown 
Signed-off-by: Johannes Berg