linux.git/scripts/coccicheck, branch v6.12.80

scripts: coccicheck: Use /usr/bin/env

2023-02-25T19:11:06+00:00

If bash is not located under /bin, coccicheck fails to run.  In the real
world, this happens for instance when NixOS is used in the host.  Instead,
use /usr/bin/env to locate the executable binary for bash.

Signed-off-by: Jarkko Sakkinen 
Tested-by: Deepak R Varma 
Signed-off-by: Julia Lawall

scripts: coccicheck: Avoid warning about spurious escape

2023-02-25T19:08:50+00:00

e.g.
grep: warning: stray \ before -

Signed-off-by: Peter Foley 
Signed-off-by: Julia Lawall

scripts: coccicheck: use "grep -E" instead of "egrep"

2022-09-21T19:23:56+00:00

The latest version of grep claims that egrep is now obsolete so the build
now contains warnings that look like:
        egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the vdso Makefile to use "grep -E" instead.

Cc: Julia Lawall 
Cc: Nicolas Palix 
Cc: cocci@inria.fr
Signed-off-by: Greg Kroah-Hartman

scripts: coccicheck: fix troubles on non-English builds

2021-05-18T09:09:59+00:00

When LANG is not set to English, the logic which checks the
number of CPUs fail, as the messages can be localized, and
the logic at:

    THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]")

will not get the number of threads per core.

This causes the script to not run properly, as it will produce
a warning:

	$ make coccicheck COCCI=$PWD/scripts/coccinelle/misc/add_namespace.cocci MODE=report drivers/media/
	./scripts/coccicheck: linha 93: [: número excessivo de argumentos

Fix it by forcing LANG=C when calling lscpu.

Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Julia Lawall

scripts: coccicheck: Correct usage of make coccicheck

2020-12-24T11:59:43+00:00

The command "make coccicheck C=1 CHECK=scripts/coccicheck" results in the
error:
        ./scripts/coccicheck: line 65: -1: shift count out of range

This happens because every time the C variable is specified,
the shell arguments need to be "shifted" in order to take only
the last argument, which is the C file to test. These shell arguments
mostly comprise flags that have been set in the Makefile. However,
when coccicheck is specified in the make command as a rule, the
number of shell arguments is zero, thus passing the invalid value -1
to the shift command, resulting in an error.

Modify coccicheck to print correct usage of make coccicheck so as to
avoid the error.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

kbuild: do not use scripts/ld-version.sh for checking spatch version

2020-12-12T17:31:29+00:00

scripts/ld-version.sh was, as its file name implies, originally intended
for the GNU ld version, but is (ab)used for the spatch version too.

Use 'sort -CV' for the version comparison, then coccicheck does not need
to use scripts/ld-version.sh. Fix nsdeps as well.

Signed-off-by: Masahiro Yamada 
Signed-off-by: Julia Lawall

scripts: coccicheck: Change default condition for parallelism

2020-10-12T08:37:56+00:00

Currently, Coccinelle uses at most one thread per core by default in
machines with more than 2 hyperthreads. However, for systems with only 4
hyperthreads, this does not improve performance.

Modify coccicheck to use all available threads in machines with
upto 4 hyperthreads.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

scripts: coccicheck: Add quotes to improve portability

2020-10-12T08:32:40+00:00

While fetching the number of threads per core with lscpu,
the [:digit:] set is used for translation of digits from 0-9.
However, using [:digit:] instead of "[:digit:]" does not seem
to work uniformly for some shell types and configurations
(such as zsh).

Therefore, modify coccicheck to use double quotes around the
[:digit:] set for uniformity and better portability.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

scripts: coccicheck: Change default value for parallelism

2020-09-27T20:52:59+00:00

By default, coccicheck utilizes all available threads to implement
parallelisation. However, when all available threads are used,
a decrease in performance is noted. The elapsed time is  minimum
when at most one thread per core is used.

For example, on benchmarking the semantic patch kfree.cocci for
usb/serial using hyperfine, the outputs obtained for J=5 and J=2
are 1.32 and 1.90 times faster than those for J=10 and J=9
respectively for two separate runs. For the larger drivers/staging
directory, minimium elapsed time is obtained for J=3 which is 1.86
times faster than that for J=12. The optimal J value does not
exceed 6 in any of the test runs. The benchmarks are run on a machine
with 6 cores, with 2 threads per core, i.e, 12 hyperthreads in all.

To improve performance, modify coccicheck to use at most only
one thread per core by default.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall

scripts: coccicheck: Improve error feedback when coccicheck fails

2020-09-13T20:13:01+00:00

Currently, coccicheck fails with only the message "coccicheck failed"
and the error code for the failure. To obtain the error logs,
one needs to specify a debug file using the DEBUG_FILE option.

Modify coccicheck to display error logs when it crashes unless
DEBUG_FILE is set, in which case, the error logs are stored in
the specified debug file.

Signed-off-by: Sumera Priyadarsini 
Signed-off-by: Julia Lawall