linux.git/scripts/coccinelle/misc, branch v6.12.80

coccinelle: misc: minmax: Suppress reports for err returns

2024-05-20T19:31:20+00:00

Most of the people prefer:

return ret < 0 ? ret: 0;

than:

return min(ret, 0);

Let's tweak the cocci file to ignore those lines completely.

Signed-off-by: Ricardo Ribalda 
Signed-off-by: Julia Lawall

coccinelle: semantic patch to check for potential struct_size calls

2024-02-29T21:38:01+00:00

include/linux/overflow.h includes helper macros intended for calculating
sizes of allocations. These macros prevent accidental overflow by
saturating at SIZE_MAX.

In general when calculating such sizes use of the macros is preferred. Add
a semantic patch which can detect code patterns which can be replaced by
struct_size.

Note that I set the confidence to medium because this patch doesn't make an
attempt to ensure that the relevant array is actually a flexible array. The
struct_size macro does specifically require a flexible array. In many cases
the detected code could be refactored to a flexible array, but this is not
always possible (such as if there are multiple over-allocations).

Signed-off-by: Jacob Keller 
Link: https://lore.kernel.org/r/20230227202428.3657443-1-jacob.e.keller@intel.com
Signed-off-by: Kees Cook

update Coccinelle URL

2022-08-07T19:30:36+00:00

Signed-off-by: Julia Lawall

coccinelle: Remove script that checks replacing 0/1 with false/true in functions returning bool

2022-07-16T13:31:33+00:00

There is nothing wrong with current code that returns 0 or 1 for a
function returning bool. It is perfectly acceptable by the C standard.

To avoid churn of unwanted patches that are constantly sent to maintainers
who do not care about this change, remove the script that flags it as an
issue. This issue is not worth the burden on maintainers to accept
useless patches.

Link: https://lore.kernel.org/all/20220705073822.7276-1-jiapeng.chong@linux.alibaba.com/
Link: https://lore.kernel.org/all/20220429075201.68581-1-jiapeng.chong@linux.alibaba.com/
Link: https://lore.kernel.org/all/1649236467-29390-1-git-send-email-baihaowen@meizu.com/
Link: https://lore.kernel.org/all/20220317014740.3138-1-jiapeng.chong@linux.alibaba.com/
Link: https://lore.kernel.org/all/190b5c2f2f2fb9cc775fce8daed72bf893be48a4.1642065293.git.davidcomponentone@gmail.com/
Link: https://lore.kernel.org/all/20211214113845.439392-1-deng.changcheng@zte.com.cn/
Link: https://lore.kernel.org/all/20210824065735.60660-1-deng.changcheng@zte.com.cn/
Link: https://lore.kernel.org/all/20210824064305.60081-1-deng.changcheng@zte.com.cn/
Link: https://lore.kernel.org/all/20210824062359.59474-1-deng.changcheng@zte.com.cn/

Cc: Rasmus Villemoes 
Cc: Julia Lawall 
Cc: Michal Marek 
Cc: Peter Zijlstra 
Signed-off-by: Steven Rostedt (Google) 
Signed-off-by: Julia Lawall 
Acked-by: Rasmus Villemoes 
Acked-by: Paul Gortmaker

coccinelle: Extend address test from ifaddr semantic patch to test expressions

2022-07-03T21:45:05+00:00

The test of an expression's address does not necessarily represent the
whole condition, it may only be a part of it. Also, an expression's
address is likely to be non-zero in every test expression, not only in
if statements.

This change aims at detecting an address test in more complex conditions
and not only in if statements.

Signed-off-by: Jérémy Lefaure 
Signed-off-by: Julia Lawall

scripts/coccinelle: drop bugon.cocci

2022-01-15T11:15:35+00:00

The BUG_ON script was never safe, in that it was not able to check
whether the condition was side-effecting.  At this point, BUG_ON
should be well known, so it has probably outlived its usefuless.

Signed-off-by: Julia Lawall 
Suggested-by: Matthew Wilcox

coccinelle: semantic patch to check for inappropriate do_div() calls

2021-09-11T20:57:39+00:00

do_div() does a 64-by-32 division.
When the divisor is unsigned long, u64, or s64,
do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.
This semantic patch is inspired by Mateusz Guzik's patch:
commit b0ab99e7736a ("sched: Fix possible divide by zero in avg_atom() calculation")

Signed-off-by: Wen Yang 
Signed-off-by: Julia Lawall 
Cc: Gilles Muller 
Cc: Nicolas Palix 
Cc: Michal Marek 
Cc: Matthias Maennich 
Cc: Greg Kroah-Hartman 
Cc: Masahiro Yamada 
Cc: Thomas Gleixner 
Cc: cocci@systeme.lip6.fr
Cc: linux-kernel@vger.kernel.org

coccinelle: misc: minmax: suppress patch generation for err returns

2021-05-01T19:27:10+00:00

There is a standard idiom for "if 'ret' holds an error, return it":
	return ret < 0 ? ret : 0;

Developers prefer to keep the things as they are because stylistic
change to "return min(ret, 0);" breaks readability.

Let's suppress automatic generation for this type of patches.

Signed-off-by: Denis Efremov

coccinelle: irqf_oneshot: reduce the severity due to false positives

2021-05-01T19:23:57+00:00

The IRQF_ONESHOT should be present for threaded IRQ using default
primary handler.  However intetrupt of many child devices, e.g. children
of MFD, is nested thus the IRQF_ONESHOT is not needed.  The coccinelle
message about error misleads submitters and reviewers about the severity
of the issue, so make it a warning and mention possible false positive.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Julia Lawall

coccinelle: misc: add swap script

2021-05-01T19:23:56+00:00

Check for opencoded swap() implementation.

Signed-off-by: Denis Efremov 
Signed-off-by: Julia Lawall