linux.git/scripts/sign-file.c, branch v6.18.21

sign-file,extract-cert: use pkcs11 provider for OPENSSL MAJOR >= 3

2024-09-20T16:52:48+00:00

ENGINE API has been deprecated since OpenSSL version 3.0 [1].
Distros have started dropping support from headers and in future
it will likely disappear also from library.

It has been superseded by the PROVIDER API, so use it instead
for OPENSSL MAJOR >= 3.

[1] https://github.com/openssl/openssl/blob/master/README-ENGINES.md

[jarkko: fixed up alignment issues reported by checkpatch.pl --strict]

Signed-off-by: Jan Stancek 
Reviewed-by: Jarkko Sakkinen 
Tested-by: R Nageswara Sastry 
Reviewed-by: Neal Gompa 
Signed-off-by: Jarkko Sakkinen

sign-file,extract-cert: avoid using deprecated ERR_get_error_line()

2024-09-20T16:49:52+00:00

ERR_get_error_line() is deprecated since OpenSSL 3.0.

Use ERR_peek_error_line() instead, and combine display_openssl_errors()
and drain_openssl_errors() to a single function where parameter decides
if it should consume errors silently.

Signed-off-by: Jan Stancek 
Reviewed-by: Jarkko Sakkinen 
Tested-by: R Nageswara Sastry 
Reviewed-by: Neal Gompa 
Signed-off-by: Jarkko Sakkinen

sign-file,extract-cert: move common SSL helper functions to a header

2024-09-20T16:49:52+00:00

Couple error handling helpers are repeated in both tools, so
move them to a common header.

Signed-off-by: Jan Stancek 
Reviewed-by: Jarkko Sakkinen 
Tested-by: R Nageswara Sastry 
Reviewed-by: Neal Gompa 
Signed-off-by: Jarkko Sakkinen

sign-file: Fix incorrect return values check

2023-12-13T20:55:11+00:00

There are some wrong return values check in sign-file when call OpenSSL
API. The ERR() check cond is wrong because of the program only check the
return value is < 0 which ignored the return val is 0. For example:
1. CMS_final() return 1 for success or 0 for failure.
2. i2d_CMS_bio_stream() returns 1 for success or 0 for failure.
3. i2d_TYPEbio() return 1 for success and 0 for failure.
4. BIO_free() return 1 for success and 0 for failure.

Link: https://www.openssl.org/docs/manmaster/man3/
Fixes: e5a2e3c84782 ("scripts/sign-file.c: Add support for signing with a raw signature")
Signed-off-by: Yusong Gao 
Reviewed-by: Juerg Haefliger 
Signed-off-by: David Howells 
Link: https://lore.kernel.org/r/20231213024405.624692-1-a869920004@gmail.com/ # v5
Signed-off-by: Linus Torvalds

sign-file: Fix confusing error messages

2022-08-03T20:56:20+00:00

When an error occurs, use errx() instead of err() to display the
error message, because openssl has its own error record. When an
error occurs, errno will not be changed, while err() displays the
errno error message. It will cause confusion. For example, when
CMS_add1_signer() fails, the following message will appear:

  sign-file: CMS_add1_signer: Success

errx() ignores errno and does not cause such issue.

Signed-off-by: Tianjia Zhang 
Reviewed-by: Jarkko Sakkinen 
Signed-off-by: Jarkko Sakkinen

cert host tools: Stop complaining about deprecated OpenSSL functions

2022-06-08T20:18:39+00:00

OpenSSL 3.0 deprecated the OpenSSL's ENGINE API.  That is as may be, but
the kernel build host tools still use it.  Disable the warning about
deprecated declarations until somebody who cares fixes it.

Signed-off-by: Linus Torvalds

sign-file: fix build error in sign-file.c with libressl

2017-02-10T01:43:47+00:00

The sign-file tool failed to build against libressl. Fix this by extending
the PKCS7 check and thus making sign-file link against libressl without an
error.

Signed-off-by: John Crispin 
Signed-off-by: Felix Fietkau 
Signed-off-by: David Howells 
Signed-off-by: James Morris

Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6

2016-12-15T19:41:37+00:00

Pull crypto fixes from Herbert Xu:
 "This fixes the following issues:

   - a crash regression in the new skcipher walker

   - incorrect return value in public_key_verify_signature

   - fix for in-place signing in the sign-file utility"

* 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
  crypto: skcipher - fix crash in virtual walk
  sign-file: Fix inplace signing when src and dst names are both specified
  crypto: asymmetric_keys - set error code on failure

sign-file: Fix inplace signing when src and dst names are both specified

2016-12-14T10:33:14+00:00

When src and dst both are specified and they point to the same file
the sign-file utility will write only signature to the dst file and
the module (.ko file) body will not be written.
That happens because we open the same file with "rb" and "wb" flags,
from fopen man:

 w      Truncate file to zero length or create text file for writing.
The stream is positioned at the beginning of the file.
...
	bm = BIO_new_file(module_name, "rb");
...
	bd = BIO_new_file(dest_name, "wb");
...
	while ((n = BIO_read(bm, buf, sizeof(buf))),
	       n > 0) {
		ERR(BIO_write(bd, buf, n) < 0, "%s", dest_name);
	}
...

Signed-off-by: Alex Yashchenko 
Signed-off-by: David Howells 
Signed-off-by: Herbert Xu

treewide: Make remaining source files non-executable

2016-12-13T04:41:52+00:00

.c and .h source files should not be executable, change
the permissions to 0644.

[ This would normally go through Andrew Morton, but his ancient
  patch-based toolchain doesn't do permission changes ]

Signed-off-by: Joe Perches 
Acked-by: David Howells 
Signed-off-by: Linus Torvalds