linux.git/sound/core/seq, branch v2.6.35-rc4

ALSA: core - Define llseek fops

2010-04-13T10:01:21+00:00

Set no_llseek to llseek file ops of each sound component (but for hwdep).
This avoids the implicit BKL invocation via generic_file_llseek() used
as default when fops.llseek is NULL.

Also call nonseekable_open() at each open ops to ensure the file flags
have no seek bit.

Signed-off-by: Takashi Iwai

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

2010-03-30T13:02:32+00:00

percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files.  percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.

percpu.h -> slab.h dependency is about to be removed.  Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability.  As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.

  http://userweb.kernel.org/~tj/misc/slabh-sweep.py

The script does the followings.

* Scan files for gfp and slab usages and update includes such that
  only the necessary includes are there.  ie. if only gfp is used,
  gfp.h, if slab is used, slab.h.

* When the script inserts a new include, it looks at the include
  blocks and try to put the new include such that its order conforms
  to its surrounding.  It's put in the include block which contains
  core kernel includes, in the same order that the rest are ordered -
  alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
  doesn't seem to be any matching order.

* If the script can't find a place to put a new include (mostly
  because the file doesn't have fitting include block), it prints out
  an error message indicating which .h file needs to be added to the
  file.

The conversion was done in the following steps.

1. The initial automatic conversion of all .c files updated slightly
   over 4000 files, deleting around 700 includes and adding ~480 gfp.h
   and ~3000 slab.h inclusions.  The script emitted errors for ~400
   files.

2. Each error was manually checked.  Some didn't need the inclusion,
   some needed manual addition while adding it to implementation .h or
   embedding .c file was more appropriate for others.  This step added
   inclusions to around 150 files.

3. The script was run again and the output was compared to the edits
   from #2 to make sure no file was left behind.

4. Several build tests were done and a couple of problems were fixed.
   e.g. lib/decompress_*.c used malloc/free() wrappers around slab
   APIs requiring slab.h to be added manually.

5. The script was run on all .h files but without automatically
   editing them as sprinkling gfp.h and slab.h inclusions around .h
   files could easily lead to inclusion dependency hell.  Most gfp.h
   inclusion directives were ignored as stuff from gfp.h was usually
   wildly available and often used in preprocessor macros.  Each
   slab.h inclusion directive was examined and added manually as
   necessary.

6. percpu.h was updated not to include slab.h.

7. Build test were done on the following configurations and failures
   were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
   distributed build env didn't work with gcov compiles) and a few
   more options had to be turned off depending on archs to make things
   build (like ipr on powerpc/64 which failed due to missing writeq).

   * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
   * powerpc and powerpc64 SMP allmodconfig
   * sparc and sparc64 SMP allmodconfig
   * ia64 SMP allmodconfig
   * s390 SMP allmodconfig
   * alpha SMP allmodconfig
   * um on x86_64 SMP allmodconfig

8. percpu.h modifications were reverted so that it could be applied as
   a separate patch and serve as bisection point.

Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.

Signed-off-by: Tejun Heo 
Guess-its-ok-by: Christoph Lameter 
Cc: Ingo Molnar 
Cc: Lee Schermerhorn

ALSA: trivial: sound seq ioctl dbg: print hexadecimal value padded with 0s

2010-02-01T23:27:47+00:00

Instead of padding with blanks and printing "number=0x a", print
"number=0x0a".

Signed-off-by: Thadeu Lima de Souza Cascardo 
Signed-off-by: Takashi Iwai

sound: seq_timer: simplify snd_seq_timer_set_tick_resolution() parameters

2010-01-18T15:38:30+00:00

As snd_seq_timer_set_tick_resolution() is always called with the same
three fields of struct snd_seq_timer, it suffices to give that as the
only parameter.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Jaroslav Kysela

Merge branch 'topic/midi' into for-linus

2009-09-10T13:32:56+00:00

* topic/midi:
  sound: rawmidi: disable active-sensing-on-close by default
  sound: seq_oss_midi: remove magic numbers
  sound: seq_midi: do not send MIDI reset when closing
  seq-midi: always log message on output overrun

ALSA: OSS sequencer should be initialized after snd_seq_system_client_init

2009-07-19T17:10:01+00:00

When build SND_SEQUENCER in kernel then OSS sequencer(alsa_seq_oss_init)
is initialized before System (snd_seq_system_client_init) which leads to
memory leak :

unreferenced object 0xf6b0e680 (size 256):
  comm "swapper", pid 1, jiffies 4294670753
  backtrace:
    [] create_object+0x135/0x204
    [] kmemleak_alloc+0x26/0x4c
    [] kmem_cache_alloc+0x72/0xff
    [] seq_create_client1+0x22/0x160
    [] snd_seq_create_kernel_client+0x72/0xef
    [] snd_seq_oss_create_client+0x86/0x142
    [] alsa_seq_oss_init+0xf6/0x155
    [] do_one_initcall+0x4f/0x111
    [] kernel_init+0x115/0x166
    [] kernel_thread_helper+0x7/0x10
    [] 0xffffffff
unreferenced object 0xf688a580 (size 64):
  comm "swapper", pid 1, jiffies 4294670753
  backtrace:
    [] create_object+0x135/0x204
    [] kmemleak_alloc+0x26/0x4c
    [] kmem_cache_alloc+0x72/0xff
    [] snd_seq_pool_new+0x1c/0xb8
    [] seq_create_client1+0x87/0x160
    [] snd_seq_create_kernel_client+0x72/0xef
    [] snd_seq_oss_create_client+0x86/0x142
    [] alsa_seq_oss_init+0xf6/0x155
    [] do_one_initcall+0x4f/0x111
    [] kernel_init+0x115/0x166
    [] kernel_thread_helper+0x7/0x10
    [] 0xffffffff
unreferenced object 0xf6b0e480 (size 256):
  comm "swapper", pid 1, jiffies 4294670754
  backtrace:
    [] create_object+0x135/0x204
    [] kmemleak_alloc+0x26/0x4c
    [] kmem_cache_alloc+0x72/0xff
    [] snd_seq_create_port+0x51/0x21c
    [] snd_seq_ioctl_create_port+0x57/0x13c
    [] snd_seq_do_ioctl+0x4a/0x69
    [] snd_seq_kernel_client_ctl+0x33/0x49
    [] snd_seq_oss_create_client+0xf5/0x142
    [] alsa_seq_oss_init+0xf6/0x155
    [] do_one_initcall+0x4f/0x111
    [] kernel_init+0x115/0x166
    [] kernel_thread_helper+0x7/0x10
    [] 0xffffffff

The correct order should be :

System (snd_seq_system_client_init) should be initialized before
OSS sequencer(alsa_seq_oss_init) which is equivalent to :

1. insmod sound/core/seq/snd-seq-device.ko
2. insmod sound/core/seq/snd-seq.ko
3. insmod sound/core/seq/snd-seq-midi-event.ko
4. insmod sound/core/seq/oss/snd-seq-oss.ko

Including sound/core/seq/oss/Makefile after other seq modules
fixes the ordering and memory leak.

Signed-off-by: Jaswinder Singh Rajput 
Signed-off-by: Takashi Iwai

sound: rawmidi: disable active-sensing-on-close by default

2009-07-15T09:57:20+00:00

Sending an Active Sensing message when closing a port can interfere with
the following data if the port is reopened and a note-on is sent before
the device's timeout has elapsed.  Therefore, it is better to disable
this setting by default.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

sound: seq_oss_midi: remove magic numbers

2009-07-15T09:57:08+00:00

Instead of using magic numbers for the controlles sent when resetting
a port, use the symbols from asoundef.h.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

sound: seq_midi: do not send MIDI reset when closing

2009-07-15T09:56:58+00:00

Sending a MIDI reset message when closing a port is wrong because we
only want to shut the device up, not to reset all settings.
Furthermore, many devices ignore this message.

Fortunately, the RawMIDI layer already shuts the device up, so we can
ignore this matter here.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

seq-midi: always log message on output overrun

2009-07-15T09:56:06+00:00

It turns out that the main cause of output buffer overruns is not slow
drivers but applications that generate too many messages.  Therefore, it
makes more sense to make that error message always visible, and to
rate-limit it.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai