linux.git/sound/core/timer.c, branch v2.6.35-rc4

Merge branch 'topic/core-cleanup' into for-linus

2010-05-20T09:58:57+00:00

ALSA: take tu->qlock with irqs disabled

2010-05-05T07:57:08+00:00

We should disable irqs when we take the tu->qlock because it is used in
the irq handler.  The only place that doesn't is
snd_timer_user_ccallback().  Most of the time snd_timer_user_ccallback()
is called with interrupts disabled but the the first ti->ccallback()
call in snd_timer_notify1() has interrupts enabled.

This was caught by lockdep which generates the following message:

> =================================
> [ INFO: inconsistent lock state ]
> 2.6.34-rc5 #5
> ---------------------------------
> inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
> dolphin/4003 [HC1[1]:SC0[0]:HE0:SE1] takes:
> (&(&tu->qlock)->rlock){?.+...}, at: [] snd_timer_user_tinterrupt+0x28/0x132 [snd_timer]
> {HARDIRQ-ON-W} state was registered at:
>   [] __lock_acquire+0x654/0x1482
>   [] lock_acquire+0x5c/0x73
>   [] _raw_spin_lock+0x25/0x34
>   [] snd_timer_user_ccallback+0x55/0x95 [snd_timer]
>   [] snd_timer_notify1+0x53/0xca [snd_timer]

Reported-by: Stefan Richter 
Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

ALSA: core - Define llseek fops

2010-04-13T10:01:21+00:00

Set no_llseek to llseek file ops of each sound component (but for hwdep).
This avoids the implicit BKL invocation via generic_file_llseek() used
as default when fops.llseek is NULL.

Also call nonseekable_open() at each open ops to ensure the file flags
have no seek bit.

Signed-off-by: Takashi Iwai

ALSA: timer - pass real event in snd_timer_notify1() to instance callback

2010-03-03T21:39:45+00:00

Do not use hardcoded SNDRV_TIMER_EVENT_START value.

Signed-off-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai

ALSA: sound/core: use memdup_user()

2009-04-14T10:39:12+00:00

Remove open-coded memdup_user().

Signed-off-by: Li Zefan 
Signed-off-by: Takashi Iwai

Rationalize fasync return values

2009-03-16T14:34:35+00:00

Most fasync implementations do something like:

     return fasync_helper(...);

But fasync_helper() will return a positive value at times - a feature used
in at least one place.  Thus, a number of other drivers do:

     err = fasync_helper(...);
     if (err < 0)
             return err;
     return 0;

In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.

Cc: Al Viro 
Signed-off-by: Jonathan Corbet

ALSA: hda - Convert from takslet_hi_schedule() to tasklet_schedule()

2008-12-18T11:17:55+00:00

Replace all tasklet_hi_schedule() callers with the normal
tasklet_schedule().  The former often causes troubles with
RT-kernels, and has actually no merit.

Signed-off-by: Takashi Iwai

saner FASYNC handling on file close

2008-11-01T16:49:46+00:00

As it is, all instances of ->release() for files that have ->fasync()
need to remember to evict file from fasync lists; forgetting that
creates a hole and we actually have a bunch that *does* forget.

So let's keep our lives simple - let __fput() check FASYNC in
file->f_flags and call ->fasync() there if it's been set.  And lose that
crap in ->release() instances - leaving it there is still valid, but we
don't have to bother anymore.

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

ALSA: fix a typo during snd_assert() removal

2008-08-15T09:48:04+00:00

Signed-off-by: Takashi Iwai 
Signed-off-by: Jaroslav Kysela

ALSA: Kill snd_assert() in sound/core/*

2008-08-13T09:46:35+00:00

Kill snd_assert() in sound/core/*, either removed or replaced with
if () with snd_BUG_ON().

Signed-off-by: Takashi Iwai 
Signed-off-by: Jaroslav Kysela