linux.git/sound/soc/sof/imx, branch v5.15.142

ASoC: SOF: Add missing of_node_put() in imx8m_probe

2022-04-08T12:23:21+00:00

[ Upstream commit 5575f7f49134c7386a684335c9007737c606d3b5 ]

The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

Fixes: afb93d716533 ("ASoC: SOF: imx: Add i.MX8M HW support")
Signed-off-by: Miaoqian Lin 
Reviewed-by: Peter Ujfalusi 
Link: https://lore.kernel.org/r/20220308023325.31702-1-linmq006@gmail.com
Signed-off-by: Mark Brown 
Signed-off-by: Sasha Levin

ASoC: SOF: imx: imx8m: Bar index is only valid for IRAM and SRAM types

2021-09-15T15:23:49+00:00

i.MX8 only uses SOF_FW_BLK_TYPE_IRAM (1) and SOF_FW_BLK_TYPE_SRAM (3)
bars, everything else is left as 0 in sdev->bar[] array.

If a broken or purposefully crafted firmware image is loaded with other
types of FW_BLK_TYPE then a kernel crash can be triggered.

Make sure that only IRAM/SRAM type is converted to bar index.

Fixes: afb93d716533d ("ASoC: SOF: imx: Add i.MX8M HW support")
Signed-off-by: Peter Ujfalusi 
Reviewed-by: Daniel Baluta 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Guennadi Liakhovetski 
Link: https://lore.kernel.org/r/20210915122116.18317-6-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: imx8: Bar index is only valid for IRAM and SRAM types

2021-09-15T15:23:48+00:00

i.MX8 only uses SOF_FW_BLK_TYPE_IRAM (1) and SOF_FW_BLK_TYPE_SRAM (3)
bars, everything else is left as 0 in sdev->bar[] array.

If a broken or purposefully crafted firmware image is loaded with other
types of FW_BLK_TYPE then a kernel crash can be triggered.

Make sure that only IRAM/SRAM type is converted to bar index.

Fixes: 202acc565a1f0 ("ASoC: SOF: imx: Add i.MX8 HW support")
Signed-off-by: Peter Ujfalusi 
Reviewed-by: Daniel Baluta 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Guennadi Liakhovetski 
Link: https://lore.kernel.org/r/20210915122116.18317-5-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: Add missing of_node_put() in imx8_probe()

2021-06-22T11:47:13+00:00

This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. of_node_put() on it before exiting
this function.

Signed-off-by: Yang Yingliang 
Link: https://lore.kernel.org/r/20210617032756.599359-1-yangyingliang@huawei.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: update kernel-doc description

2020-12-11T13:23:03+00:00

Add missing parameters to avoid W=1 error

Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Daniel Baluta 
Signed-off-by: Kai Vehmanen 
Link: https://lore.kernel.org/r/20201211102255.3189589-1-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: fix Kconfig punctuation

2020-11-12T17:17:57+00:00

Add periods at the end of sentences in help text.

Signed-off-by: Randy Dunlap 
Signed-off-by: Pierre-Louis Bossart 
Reviewed-by: Ranjani Sridharan 
Reviewed-by: Rander Wang 
Reviewed-by: Guennadi Liakhovetski 
Link: https://lore.kernel.org/r/20201112164425.25603-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: add missing MODULE_LICENSE() for imx-common

2020-09-21T16:28:11+00:00

Fix build warning:
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/sof/imx/imx-common.o

Fixes: 18ebffe4d043 ("ASoC: SOF: imx: Add debug support for imx platforms")
Reported-by: Stephen Rothwell 
Signed-off-by: Kai Vehmanen 
Reviewed-by: Daniel Baluta 
Reviewed-by: Pierre-Louis Bossart 
Link: https://lore.kernel.org/r/20200921104746.2903507-1-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: Add debug support for imx platforms

2020-09-17T14:53:15+00:00

This patch adds debug support for imx platforms. This is important in
order to gather information about the state of the DSP in case of an
oops and the reason for the oops.

This is done by checking if a message with a panic code has been placed
in the debug box, in the imx8_dsp_handle_request function from sof/imx.

If positive, the function imx8_dump, added in common, will be called.
The first step is to gather information about the registers, filename,
line number and stack by calling the imx8_get_registers, added in common.
Then the information will be printed to the console by calling the
get_status function.

Signed-off-by: Iulian Olaru 
Reviewed-by: Guennadi Liakhovetski 
Reviewed-by: Daniel Baluta 
Signed-off-by: Kai Vehmanen 
Link: https://lore.kernel.org/r/20200917105633.2579047-2-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: sof-of-dev: Add .arch_ops field

2020-08-26T12:19:16+00:00

Add .arch_ops field in the sof_imx8x_ops structure.
The inclusion of this field will allow the usage of functions from
sof/core.c in order to print debug information such as the registers and
a stack dump in case of a firmware ops.

The SND_SOC_SOF_XTENSA is added in the imx/Kconfig file so the compilation
is successful.

Signed-off-by: Iulian Olaru 
Reviewed-by: Pierre-Louis Bossart 
Reviewed-by: Daniel Baluta 
Signed-off-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20200825235040.1586478-8-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown

ASoC: SOF: imx: Replace sdev->private with sdev->pdata->hw_pdata

2020-08-26T12:19:16+00:00

The correct way to save private data is to use sdev->pdata->hw_pdata.
Removed superfluous type-casts.

Signed-off-by: Iulian Olaru 
Reviewed-by: Daniel Baluta 
Reviewed-by: Pierre-Louis Bossart 
Signed-off-by: Ranjani Sridharan 
Link: https://lore.kernel.org/r/20200825235040.1586478-7-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown