linux.git/tools/perf/util/expr.y, branch v6.12.80

perf expr: Make YYDEBUG dependent on doing a debug build

2023-09-12T20:46:50+00:00

YYDEBUG enables line numbers and other error helpers in the generated
expr-bison.c. These shouldn't be generated when debugging
isn't enabled.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Gaosheng Cui 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Kan Liang 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Rob Herring 
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20230911170559.4037734-3-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf jevents: Add a new expression builtin strcmp_cpuid_str()

2023-08-17T17:12:14+00:00

This will allow writing formulas that are conditional on a specific
CPU type or CPU version. It calls through to the existing
strcmp_cpuid_str() function in Perf which has a default weak version,
and an arch specific version for x86 and arm64.

The function takes an 'ID' type value, which is a string. But in this
case Arm CPU IDs are hex numbers prefixed with '0x'. metric.py
assumes strings are only used by event names, and that they can't start
with a number ('0'), so an additional change has to be made to the
regex to convert hex numbers back to 'ID' types.

Signed-off-by: James Clark 
Reviewed-by: John Garry 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Eduard Zingerman 
Cc: Haixin Yu 
Cc: Ian Rogers 
Cc: Ingo Molnar 
Cc: Jing Zhang 
Cc: Jiri Olsa 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Mark Rutland 
Cc: Mike Leach 
Cc: Namhyung Kim 
Cc: Nick Forrington 
Cc: Peter Zijlstra 
Cc: Rob Herring 
Cc: Sohom Datta 
Cc: Will Deacon 
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20230816114841.1679234-5-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf build: Disable fewer bison warnings

2023-08-03T20:01:24+00:00

If bison is version 3.8.2, reduce the number of bison C warnings
disabled. Earlier bison versions have all C warnings disabled. Avoid
implicit declarations of yylex by adding the declaration in the C
file. A header can't be included as a circular dependency would occur
due to the lexer using the bison defined tokens.

Committer notes:

Some recent versions of gcc and clang (noticed on Alpine Linux 3.17,
edge, clearlinux, fedora 37, etc.

Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Andrii Nakryiko 
Cc: Eduard Zingerman 
Cc: Gaosheng Cui 
Cc: Ingo Molnar 
Cc: Jiri Olsa 
Cc: Kan Liang 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Nathan Chancellor 
Cc: Nick Desaulniers 
Cc: Peter Zijlstra 
Cc: Rob Herring 
Cc: Tom Rix 
Cc: bpf@vger.kernel.org
Cc: llvm@lists.linux.dev
Link: https://lore.kernel.org/r/20230728064917.767761-6-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Add has_event function

2023-06-30T05:13:15+00:00

Some events are dependent on firmware/kernel enablement. Allow such
events to be detected when the metric is parsed so that the metric's
event parsing doesn't fail.

Signed-off-by: Ian Rogers 
Tested-by: Namhyung Kim 
Cc: Mark Rutland 
Cc: Eduard Zingerman 
Cc: Sohom Datta 
Cc: Peter Zijlstra 
Cc: Adrian Hunter 
Cc: Caleb Biggers 
Cc: Edward Baker 
Cc: Perry Taylor 
Cc: Samantha Alt 
Cc: Weilin Wang 
Cc: Arnaldo Carvalho de Melo 
Cc: Andrii Nakryiko 
Cc: Jiri Olsa 
Cc: Jing Zhang 
Cc: Kajol Jain 
Cc: Alexander Shishkin 
Cc: Kan Liang 
Cc: Zhengjun Xing 
Cc: John Garry 
Cc: Ingo Molnar 
Link: https://lore.kernel.org/r/20230623151016.4193660-2-irogers@google.com
Signed-off-by: Namhyung Kim

perf expr: Make the evaluation of & and | logical and lazy

2023-06-05T18:56:14+00:00

Currently the & and | operators are only used in metric thresholds like
(from the tma_retiring metric):

tma_retiring > 0.7 | tma_heavy_operations > 0.1

Thresholds are always computed when present, but a lack of events may
mean the threshold can't be computed. This happens with the option
--metric-no-threshold for say the metric tma_retiring on Tigerlake model
CPUs.

To fully compute the threshold tma_heavy_operations is needed and it
needs the extra events of IDQ.MS_UOPS, UOPS_DECODED.DEC0,
cpu/UOPS_DECODED.DEC0,cmask=1/ and IDQ.MITE_UOPS. So
--metric-no-threshold is a useful option to reduce the number of events
needed and potentially multiplexing of events.

Rather than just fail threshold computations like this, we may know a
result from just the left or right-hand side. So, for tma_retiring if
its value is "> 0.7" we know it is over the threshold. This allows the
metric to have the threshold coloring, when possible, without all the
counters being programmed.

Reviewed-by: Kan Liang 
Signed-off-by: Ian Rogers 
Tested-by: Kan Liang 
Acked-by: Jiri Olsa 
Cc: Adrian Hunter 
Cc: Ahmad Yasin 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Andrii Nakryiko 
Cc: Caleb Biggers 
Cc: Eduard Zingerman 
Cc: Edward Baker 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Samantha Alt 
Cc: Stephane Eranian 
Cc: Weilin Wang 
Link: https://lore.kernel.org/r/20230519063719.1029596-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf metric: Change divide by zero and !support events behavior

2023-05-10T15:35:02+00:00

Division by zero causes expression parsing to fail and no metric to be
generated. This can mean for short running benchmarks metrics are not
shown. Change the behavior to make the value nan, which gets shown like:

'''
$ perf stat -M TopdownL2 true

 Performance counter stats for 'true':

         1,031,492      INST_RETIRED.ANY                 #      nan %  tma_fetch_bandwidth
                                                  #      nan %  tma_heavy_operations
                                                  #      nan %  tma_light_operations
            29,304      CPU_CLK_UNHALTED.REF_XCLK        #      nan %  tma_fetch_latency
                                                  #      nan %  tma_branch_mispredicts
                                                  #      nan %  tma_machine_clears
                                                  #      nan %  tma_core_bound
                                                  #      nan %  tma_memory_bound
         2,658,319      IDQ_UOPS_NOT_DELIVERED.CORE
            11,167      EXE_ACTIVITY.BOUND_ON_STORES
           262,058      EXE_ACTIVITY.1_PORTS_UTIL
           BR_MISP_RETIRED.ALL_BRANCHES                                            (0.00%)
           INT_MISC.RECOVERY_CYCLES_ANY                                            (0.00%)
           CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE                                        (0.00%)
           CPU_CLK_UNHALTED.THREAD                                                 (0.00%)
           UOPS_RETIRED.RETIRE_SLOTS                                               (0.00%)
           CYCLE_ACTIVITY.STALLS_MEM_ANY                                           (0.00%)
           UOPS_RETIRED.MACRO_FUSED                                                (0.00%)
           IDQ_UOPS_NOT_DELIVERED.CYCLES_0_UOPS_DELIV.CORE                                        (0.00%)
           EXE_ACTIVITY.2_PORTS_UTIL                                               (0.00%)
           CYCLE_ACTIVITY.STALLS_TOTAL                                             (0.00%)
           MACHINE_CLEARS.COUNT                                                    (0.00%)
           UOPS_ISSUED.ANY                                                         (0.00%)

       0.002864879 seconds time elapsed

       0.003012000 seconds user
       0.000000000 seconds sys
'''

When events aren't supported a count of 0 can be confusing and make
metrics look meaningful. Change these to be nan also which, with the
next change, gets shown like:

'''
$ perf stat true
 Performance counter stats for 'true':

              1.25 msec task-clock:u                     #    0.387 CPUs utilized
                 0      context-switches:u               #    0.000 /sec
                 0      cpu-migrations:u                 #    0.000 /sec
                46      page-faults:u                    #   36.702 K/sec
           255,942      cycles:u                         #    0.204 GHz                         (88.66%)
           123,046      instructions:u                   #    0.48  insn per cycle
            28,301      branches:u                       #   22.580 M/sec
             2,489      branch-misses:u                  #    8.79% of all branches
             4,719      CPU_CLK_UNHALTED.REF_XCLK:u      #    3.765 M/sec
                                                  #      nan %  tma_frontend_bound
                                                  #      nan %  tma_retiring
                                                  #      nan %  tma_backend_bound
                                                  #      nan %  tma_bad_speculation
           344,855      IDQ_UOPS_NOT_DELIVERED.CORE:u    #  275.147 M/sec
         INT_MISC.RECOVERY_CYCLES_ANY:u
           CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE:u                                        (0.00%)
           CPU_CLK_UNHALTED.THREAD:u                                               (0.00%)
           UOPS_RETIRED.RETIRE_SLOTS:u                                             (0.00%)
           UOPS_ISSUED.ANY:u                                                       (0.00%)

       0.003238142 seconds time elapsed

       0.000000000 seconds user
       0.003434000 seconds sys
'''

Ensure that nan metric values are quoted as nan isn't a valid number
in JSON.

Signed-off-by: Ian Rogers 
Tested-by: Kan Liang 
Cc: Adrian Hunter 
Cc: Ahmad Yasin 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Rajeev 
Cc: Caleb Biggers 
Cc: Edward Baker 
Cc: Florian Fischer 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kang Minchul 
Cc: Leo Yan 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Rob Herring 
Cc: Samantha Alt 
Cc: Stephane Eranian 
Cc: Sumanth Korikkar 
Cc: Suzuki Poulouse 
Cc: Thomas Richter 
Cc: Tiezhu Yang 
Cc: Weilin Wang 
Cc: Xing Zhengjun 
Cc: Yang Jihong 
Link: https://lore.kernel.org/r/20230502223851.2234828-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: More explicit NAN handling

2023-02-19T11:06:59+00:00

Comparison and logical operations on NAN won't ensure the result is
NAN. Ensure NANs are propogated so that threshold expressions like
"tma_fetch_latency > 0.1 & tma_frontend_bound > 0.15" don't yield a
number when the components are NAN.

Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Alexandre Torgue 
Cc: Andrii Nakryiko 
Cc: Athira Rajeev 
Cc: Caleb Biggers 
Cc: Eduard Zingerman 
Cc: Florian Fischer 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jing Zhang 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Leo Yan 
Cc: Mark Rutland 
Cc: Maxime Coquelin 
Cc: Namhyung Kim 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Sandipan Das 
Cc: Sean Christopherson 
Cc: Stephane Eranian 
Cc: Suzuki Poulouse 
Cc: Xing Zhengjun 
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Link: https://lore.kernel.org/r/20230219092848.639226-38-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Allow a double if expression

2022-10-06T11:03:52+00:00

Some TMA metrics have double if expressions like:

  ( CPU_CLK_UNHALTED.THREAD / 2 ) * ( 1 + CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE / CPU_CLK_UNHALTED.REF_XCLK ) ) if #core_wide < 1 else ( CPU_CLK_UNHALTED.THREAD_ANY / 2 ) if #SMT_on else CPU_CLK_UNHALTED.THREAD

This currently fails to parse as the left hand side if expression needs
to be in parentheses. By allowing the if expression to have a right hand
side that is an if expression we can parse the expression above, with
left to right evaluation order that matches languages like Python.

Signed-off-by: Ian Rogers 
Cc: Ahmad Yasin 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Caleb Biggers 
Cc: Florian Fischer 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Kshipra Bopardikar 
Cc: Mark Rutland 
Cc: Miaoqian Lin 
Cc: Namhyung Kim 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Samantha Alt 
Cc: Stephane Eranian 
Cc: Thomas Richter 
Cc: Xing Zhengjun 
Link: https://lore.kernel.org/r/20221004021612.325521-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Add source_count for aggregating events

2021-11-13T21:11:50+00:00

Events like uncore_imc/cas_count_read/ on Skylake open multiple events
and then aggregate in the metric leader. To determine the average value
per event the number of these events is needed. Add a source_count
function that returns this value by counting the number of events with
the given metric leader. For most events the value is 1 but for
uncore_imc/cas_count_read/ it can yield values like 6.

Add a generic test, but manually tested with a test metric that uses
the function.

Signed-off-by: Ian Rogers 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Ingo Molnar 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Madhavan Srinivasan 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Paul A . Clarke 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Song Liu 
Cc: Wan Jiabing 
Cc: Yury Norov 
Link: https://lore.kernel.org/r/20211111002109.194172-9-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Move ID handling to its own function

2021-11-13T21:11:50+00:00

This will facilitate sharing in a follow-on change.

Signed-off-by: Ian Rogers 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Ingo Molnar 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Madhavan Srinivasan 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Paul A . Clarke 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Song Liu 
Cc: Wan Jiabing 
Cc: Yury Norov 
Link: https://lore.kernel.org/r/20211111002109.194172-8-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo