linux.git/tools/perf, branch v5.11-rc1

perf probe: Fix memory leak when synthesizing SDT probes

2020-12-24T13:52:10+00:00

The argv_split() function must be paired with argv_free(), else we must
keep a reference to the argv array received or do the freeing ourselves,
in synthesize_sdt_probe_command() we were simply leaking that argv[]
array.

Fixes: 3b1f8311f6963cd1 ("perf probe: Add sdt probes arguments into the uprobe cmd string")
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Alexandre Truong 
Cc: Alexis Berlemont 
Cc: He Zhe 
Cc: Ian Rogers 
Cc: Ingo Molnar 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Mark Rutland 
Cc: Masami Hiramatsu 
Cc: Mathieu Poirier 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Sumanth Korikkar 
Cc: Thomas Richter 
Cc: Will Deacon 
Link: https://lore.kernel.org/r/20201224135139.GF477817@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate thread member

2020-12-24T13:05:28+00:00

A separate field isn't strictly required. The core field could be
re-used for thread IDs as a single field was used previously.

But separating them will avoid confusion and catch potential errors
where core IDs are read as thread IDs and vice versa.

Also remove the placeholder id field which is now no longer used.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-13-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate core member

2020-12-24T13:05:25+00:00

Add core as a separate member so that it doesn't have to be packed into
the int value.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-12-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate die member

2020-12-24T13:05:19+00:00

Add die as a separate member so that it doesn't have to be packed into
the int value.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-11-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate socket member

2020-12-24T13:05:04+00:00

Add socket as a separate member so that it doesn't have to be packed
into the int value.

When the socket ID was larger than 8 bits the output appeared corrupted
or incomplete.

For example, here on ThunderX2 'perf stat' reports a socket of -1 and an
invalid die number:

  ./perf stat -a --per-die
  The socket id number is too big.

  Performance counter stats for 'system wide':

  S-1-D255       128             687.99 msec cpu-clock                 #   57.240 CPUs utilized
  ...
  S36-D0         128             842.34 msec cpu-clock                 #   70.081 CPUs utilized
  ...

And with --per-core there is an entry with an invalid core ID:

  ./perf stat record -a --per-core
  The socket id number is too big.

  Performance counter stats for 'system wide':
  S-1-D255-C65535     128             671.04 msec cpu-clock                 #   54.112 CPUs utilized
  ...
  S36-D0-C0           4              28.27 msec cpu-clock                 #    2.279 CPUs utilized
  ...

This fixes the "Session topology" self test on ThunderX2.

After this fix the output contains the correct socket and die IDs and no
longer prints a warning about the size of the socket ID:

  ./perf stat --per-die -a

  Performance counter stats for 'system wide':

  S36-D0         128         169,869.39 msec cpu-clock                 #  127.501 CPUs utilized
  ...
  S3612-D0         128         169,733.05 msec cpu-clock                 #  127.398 CPUs utilized

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-10-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Add separate node member

2020-12-24T13:04:52+00:00

Add node as a separate member so that it doesn't have to be packed into
the int value.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-9-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat aggregation: Start using cpu_aggr_id in map

2020-12-24T13:04:38+00:00

Use the new cpu_aggr_id struct in the cpu map instead of int so that it
can store more data.

No functional changes.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Peter Zijlstra 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Alexander Shishkin 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-8-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf cpumap: Drop in cpu_aggr_map struct

2020-12-24T13:04:32+00:00

Replace usages of perf_cpu_map with cpu_aggr map in places that are
involved with 'perf stat' aggregation.

This will then later be changed to be a map of cpu_aggr_id rather than
an int so that more data can be stored.

No functional changes.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: John Garry 
Cc: Peter Zijlstra 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Alexander Shishkin 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-7-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf cpumap: Add new map type for aggregation

2020-12-24T13:04:24+00:00

Currently this is a duplicate of perf_cpu_map so that it can be used as
a drop in replacement.

In a later commit it will be changed from a map of ints to use the new
cpu_aggr_id struct.

No functional changes.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-6-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo

perf stat: Replace aggregation ID with a struct

2020-12-24T13:04:19+00:00

Replace all occurences of the usage of int with the new struct
cpu_aggr_id.

No functional changes.

Signed-off-by: James Clark 
Acked-by: Namhyung Kim 
Acked-by: Jiri Olsa 
Tested-by: Arnaldo Carvalho de Melo 
Tested-by: John Garry 
Cc: Alexander Shishkin 
Cc: Ingo Molnar 
Cc: Mark Rutland 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Link: https://lore.kernel.org/r/20201126141328.6509-5-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo