linux.git/tools/vm, branch v5.18

tools/vm/page_owner_sort.c: remove -c option

2022-04-01T18:46:09+00:00

The -c option is used to cull by stacktrace.  Now, --cull option has
been Added in page_owner_sort.c.  Culling by stacktrace is one of the
function of "--cull".  No need to set an extra parameter.  So remove -c
option.

Remove parsing of -c when parse parameter and remove "-c" from usage.

This work is coauthored by
        Shenghong Han
        Yixuan Cao
        Chongxi Zhao
        Jiajian Ye
        Yuhong Feng
        Yongqiang Liu

Link: https://lkml.kernel.org/r/20220326085920.1470081-1-zhangyinan2019@email.szu.edu.cn
Signed-off-by: Yinan Zhang 
Cc: Chongxi Zhao 
Cc: Georgi Djakov 
Cc: Jiajian Ye 
Cc: Jonathan Corbet 
Cc: Sean Anderson 
Cc: Stephen Rothwell 
Cc: Tang Bin 
Cc: Yixuan Cao 
Cc: Yongqiang Liu 
Cc: Yuhong Feng 
Cc: Zhenliang Wei 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort.c: support for user-defined culling rules

2022-03-25T02:06:45+00:00

When viewing page owner information, we may want to cull blocks of
information with our own rules.  So it is important to enhance culling
function to provide the support for customizing culling rules.
Therefore, following adjustments are made:

1. Add --cull option to support the culling of blocks of information
   with user-defined culling rules.

	./page_owner_sort   --cull=
	./page_owner_sort   --cull 

   is a single argument in the form of a comma-separated list to
  specify individual culling rules, by the sequence of keys k1,k2, ....
  Mixed use of abbreviated and complete-form of keys is allowed.

  For reference, please see the document(Documentation/vm/page_owner.rst).

Now, assuming two blocks in the input file are as follows:

	Page allocated via order 0, mask xxxx, pid 1, tgid 1 (task_name_demo)
	PFN xxxx
	 prep_new_page+0xd0/0xf8
	 get_page_from_freelist+0x4a0/0x1290
	 __alloc_pages+0x168/0x340
	 alloc_pages+0xb0/0x158

	Page allocated via order 0, mask xxxx, pid 32, tgid 32 (task_name_demo)
	PFN xxxx
	 prep_new_page+0xd0/0xf8
	 get_page_from_freelist+0x4a0/0x1290
	 __alloc_pages+0x168/0x340
	 alloc_pages+0xb0/0x158

If we want to cull the blocks by stacktrace and task command name, we can
use this command:

	./page_owner_sort   --cull=stacktrace,name

The output would be like:

	2 times, 2 pages, task_comm_name: task_name_demo
	 prep_new_page+0xd0/0xf8
	 get_page_from_freelist+0x4a0/0x1290
	 __alloc_pages+0x168/0x340
	 alloc_pages+0xb0/0x158

As we can see, these two blocks are culled successfully, for they share
the same pid and task command name.

However, if we want to cull the blocks by pid, stacktrace and task command
name, we can this command:

	./page_owner_sort   --cull=stacktrace,name,pid

The output would be like:

	1 times, 1 pages, PID 1, task_comm_name: task_name_demo
	 prep_new_page+0xd0/0xf8
	 get_page_from_freelist+0x4a0/0x1290
	 __alloc_pages+0x168/0x340
	 alloc_pages+0xb0/0x158

	1 times, 1 pages, PID 32, task_comm_name: task_name_demo
	 prep_new_page+0xd0/0xf8
	 get_page_from_freelist+0x4a0/0x1290
	 __alloc_pages+0x168/0x340
	 alloc_pages+0xb0/0x158

As we can see, these two blocks are failed to cull, for their PIDs are
different.

2. Add explanations of --cull options to the document.

This work is coauthored by
	Yixuan Cao
	Shenghong Han
	Yinan Zhang
	Chongxi Zhao
	Yuhong Feng

Link: https://lkml.kernel.org/r/20220312145834.624-1-yejiajian2018@email.szu.edu.cn
Signed-off-by: Jiajian Ye 
Cc: Yixuan Cao 
Cc: Shenghong Han 
Cc: Yinan Zhang 
Cc: Chongxi Zhao 
Cc: Yuhong Feng 
Cc: Stephen Rothwell 
Cc: Sean Anderson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort.c: support for selecting by PID, TGID or task command name

2022-03-25T02:06:45+00:00

When viewing page owner information, we may also need to select the blocks
by PID, TGID or task command name, which helps to get more accurate page
allocation information as needed.

Therefore, following adjustments are made:

1. Add three new options, including --pid, --tgid and --name, to support
   the selection of information blocks by a specific pid, tgid and task
   command name. In addtion, multiple options are allowed to be used at
   the same time.

	./page_owner_sort [input] [output] --pid 
	./page_owner_sort [input] [output] --tgid 
	./page_owner_sort [input] [output] --name 

   Assuming a scenario when a multi-threaded program, ./demo (PID =
   5280), is running, and ./demo creates a child process (PID = 5281).

	$ps
	PID   TTY        TIME   CMD
	5215  pts/0    00:00:00  bash
	5280  pts/0    00:00:00  ./demo
	5281  pts/0    00:00:00  ./demo
	5282  pts/0    00:00:00  ps

   It would be better to filter out the records with tgid=5280 and the
   task name "demo" when debugging the parent process, and the specific
   usage is

	./page_owner_sort [input] [output] --tgid 5280 --name demo

2. Add explanations of three new options, including --pid, --tgid and
   --name, to the document.

This work is coauthored by
	Shenghong Han ,
	Yixuan Cao ,
	Yinan Zhang ,
	Chongxi Zhao ,
	Yuhong Feng .

Link: https://lkml.kernel.org/r/1646835223-7584-1-git-send-email-yejiajian2018@email.szu.edu.cn
Signed-off-by: Jiajian Ye 
Cc: Sean Anderson 
Cc: Stephen Rothwell 
Cc: Zhenliang Wei 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort: support for sorting by task command name

2022-03-25T02:06:45+00:00

When viewing page owner information, we may also need to the block to be
sorted by task command name.  Therefore, the following adjustments are
made:

1. Add a member variable to record task command name of block.

2. Add a new -n option to sort the information of blocks by task command
   name.

3. Add -n option explanation in the document.

Link: https://lkml.kernel.org/r/20220306030640.43054-2-yejiajian2018@email.szu.edu.cn
Signed-off-by: Jiajian Ye 
Cc: Stephen Rothwell 
Cc: Sean Anderson 
Cc: Yixuan Cao 
Cc: Zhenliang Wei 
Cc: 
Cc: 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort: fix three trivival places

2022-03-25T02:06:45+00:00

The following adjustments are made:

1. Instead of using another array to cull the blocks after sorting,
   reuse the old array.  So there is no need to malloc a new array.

2. When enabling '-f' option to filter out the blocks which have been
   released, only add those have not been released in the list, rather
   than add all of blocks in the list and then do the filtering when
   printing the result.

3. When enabling '-c' option to cull the blocks by comparing
   stacktrace, print the stacetrace rather than the total block.

Link: https://lkml.kernel.org/r/20220306030640.43054-1-yejiajian2018@email.szu.edu.cn
Signed-off-by: Jiajian Ye 
Cc: 
Cc: Sean Anderson 
Cc: Stephen Rothwell 
Cc: Yixuan Cao 
Cc: 
Cc: Zhenliang Wei 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort.c: support sorting by tgid and update documentation

2022-03-25T02:06:45+00:00

When the "page owner" information is read, the information sorted
by TGID is expected.

As a result, the following adjustments have been made:

1. Add a new -P option to sort the information of blocks by TGID in
   ascending order.

2. Adjust the order of member variables in block_list strust to avoid
   one 4 byte hole.

3. Add -P option explanation in the document.

Link: https://lkml.kernel.org/r/20220301151438.166118-3-yejiajian2018@email.szu.edu.cn
Signed-off-by: Jiajian Ye 
Cc: Stephen Rothwell 
Cc: Yixuan Cao 
Cc: Zhenliang Wei 
Cc: Yinan Zhang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort.c: add a security check

2022-03-25T02:06:45+00:00

Add a security check after using malloc() to allocate memory.

Link: https://lkml.kernel.org/r/20220301151438.166118-2-yejiajian2018@email.szu.edu.cn
Signed-off-by: Jiajian Ye 
Cc: Stephen Rothwell 
Cc: Yinan Zhang 
Cc: Yixuan Cao 
Cc: Zhenliang Wei 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort.c: fix the instructions for use

2022-03-25T02:06:44+00:00

I noticed a discrepancy between the usage method and the code logic.

If we enable the -f option, it should be "Filter out the information of
blocks whose memory has been released".

Link: https://lkml.kernel.org/r/20220219143106.2805-1-caoyixuan2019@email.szu.edu.cn
Signed-off-by: Yixuan Cao 
Cc: Stephen Rothwell 
Cc: Sean Anderson 
Cc: Muchun Song 
Cc: Zhenliang Wei 
Cc: Tang Bin 
Cc: Yinan Zhang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort.c: delete invalid duplicate code

2022-03-25T02:06:44+00:00

I noticed that there is two invalid lines of duplicate code.  It's better
to delete it.

Link: https://lkml.kernel.org/r/20211213095743.3630-1-caoyixuan2019@email.szu.edu.cn
Signed-off-by: Yixuan Cao 
Cc: Mark Brown 
Cc: Sean Anderson 
Cc: Zhenliang Wei 
Cc: Tang Bin 
Cc: Yinan Zhang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tools/vm/page_owner_sort.c: two trivial fixes

2022-03-25T02:06:44+00:00

1) There is an unused variable. It's better to delete it.
2) One case is missing in the usage().

Link: https://lkml.kernel.org/r/20211213164518.2461-1-hanshenghong2019@email.szu.edu.cn
Signed-off-by: Shenghong Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds