summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKangjie Lu <kangjielu@gmail.com>2016-06-02 04:11:20 -0400
committerJiri Slaby <jslaby@suse.cz>2016-07-21 08:36:08 +0200
commit3360c51768c3c589e7db3f2a4308b729ebcc7bae (patch)
tree11e263069d0b480b797dbd3155519ed2995a66e8
parentf3c9e9b1296d6f958469a2b7c9b87514b047dc08 (diff)
downloadlinux-3360c51768c3c589e7db3f2a4308b729ebcc7bae.tar.gz
linux-3360c51768c3c589e7db3f2a4308b729ebcc7bae.tar.bz2
linux-3360c51768c3c589e7db3f2a4308b729ebcc7bae.zip
rds: fix an infoleak in rds_inc_info_copy
commit 4116def2337991b39919f3b448326e21c40e0dbb upstream. The last field "flags" of object "minfo" is not initialized. Copying this object out may leak kernel stack data. Assign 0 to it to avoid leak. Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
-rw-r--r--net/rds/recv.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/rds/recv.c b/net/rds/recv.c
index de339b24ca14..917f36af8d37 100644
--- a/net/rds/recv.c
+++ b/net/rds/recv.c
@@ -544,5 +544,7 @@ void rds_inc_info_copy(struct rds_incoming *inc,
minfo.fport = inc->i_hdr.h_dport;
}
+ minfo.flags = 0;
+
rds_info_copy(iter, &minfo, sizeof(minfo));
}