diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2016-08-17 23:19:01 -0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-09-29 11:14:31 +0200 |
| commit | 1334047d29ad3e40fee3bb6bdb75e1707739ad01 (patch) | |
| tree | f252b792d14912478c341fb68e1854ddb594de5f | |
| parent | 27f32d12e690e61a9b356f84e54f496a2cb64f6e (diff) | |
| download | linux-1334047d29ad3e40fee3bb6bdb75e1707739ad01.tar.gz linux-1334047d29ad3e40fee3bb6bdb75e1707739ad01.tar.bz2 linux-1334047d29ad3e40fee3bb6bdb75e1707739ad01.zip | |
asm-generic: make get_user() clear the destination on errors
commit 9ad18b75c2f6e4a78ce204e79f37781f8815c0fa upstream.
both for access_ok() failures and for faults halfway through
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | include/asm-generic/uaccess.h | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/include/asm-generic/uaccess.h b/include/asm-generic/uaccess.h index dc1269c74a52..a79424155cfe 100644 --- a/include/asm-generic/uaccess.h +++ b/include/asm-generic/uaccess.h @@ -228,14 +228,18 @@ extern int __put_user_bad(void) __attribute__((noreturn)); might_fault(); \ access_ok(VERIFY_READ, ptr, sizeof(*ptr)) ? \ __get_user(x, ptr) : \ - -EFAULT; \ + ((x) = (__typeof__(*(ptr)))0,-EFAULT); \ }) #ifndef __get_user_fn static inline int __get_user_fn(size_t size, const void __user *ptr, void *x) { - size = __copy_from_user(x, ptr, size); - return size ? -EFAULT : size; + size_t n = __copy_from_user(x, ptr, size); + if (unlikely(n)) { + memset(x + (size - n), 0, n); + return -EFAULT; + } + return 0; } #define __get_user_fn(sz, u, k) __get_user_fn(sz, u, k) |