diff options
| author | Pan Bian <bianpan2016@163.com> | 2017-04-24 18:29:16 +0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2017-07-18 18:40:39 +0100 |
| commit | 0b333ba55f7b0ccfb5e9a9b98cca22756e68c41a (patch) | |
| tree | c689c517ea6ef5d8efd4f5870c32e597f04e435f | |
| parent | 6bd1dd04eabf96e403b99ee0f86e5bbf6ebacf4a (diff) | |
| download | linux-0b333ba55f7b0ccfb5e9a9b98cca22756e68c41a.tar.gz linux-0b333ba55f7b0ccfb5e9a9b98cca22756e68c41a.tar.bz2 linux-0b333ba55f7b0ccfb5e9a9b98cca22756e68c41a.zip | |
team: fix memory leaks
commit 72ec0bc64b9a5d8e0efcb717abfc757746b101b7 upstream.
In functions team_nl_send_port_list_get() and
team_nl_send_options_get(), pointer skb keeps the return value of
nlmsg_new(). When the call to genlmsg_put() fails, the memory is not
freed(). This will result in memory leak bugs.
Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for options transfers")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/net/team/team.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 53dd41b468d5..b78532e8c56e 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -2319,8 +2319,10 @@ start_again: hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI, TEAM_CMD_OPTIONS_GET); - if (!hdr) + if (!hdr) { + nlmsg_free(skb); return -EMSGSIZE; + } if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex)) goto nla_put_failure; @@ -2587,8 +2589,10 @@ start_again: hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags | NLM_F_MULTI, TEAM_CMD_PORT_LIST_GET); - if (!hdr) + if (!hdr) { + nlmsg_free(skb); return -EMSGSIZE; + } if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex)) goto nla_put_failure; |