diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-09-10 18:44:15 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-12-10 18:01:32 +0000 |
| commit | 0669f62b66de87c6628edc6b5e7e7b317a4b8876 (patch) | |
| tree | 070102d833c2bbca41d7ec5eaef017dff05fb380 | |
| parent | 52373b487ee420c43e1d9d01b4b8c11bb6e9bdbf (diff) | |
| download | linux-0669f62b66de87c6628edc6b5e7e7b317a4b8876.tar.gz linux-0669f62b66de87c6628edc6b5e7e7b317a4b8876.tar.bz2 linux-0669f62b66de87c6628edc6b5e7e7b317a4b8876.zip | |
scsi: bfa: release allocated memory in case of error
commit 0e62395da2bd5166d7c9e14cbc7503b256a34cb0 upstream.
In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory needs to
be released.
Link: https://lore.kernel.org/r/20190910234417.22151-1-navid.emamdoost@gmail.com
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/scsi/bfa/bfad_attr.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/scsi/bfa/bfad_attr.c b/drivers/scsi/bfa/bfad_attr.c index 40be670a1cbc..408bba4001be 100644 --- a/drivers/scsi/bfa/bfad_attr.c +++ b/drivers/scsi/bfa/bfad_attr.c @@ -282,8 +282,10 @@ bfad_im_get_stats(struct Scsi_Host *shost) rc = bfa_port_get_stats(BFA_FCPORT(&bfad->bfa), fcstats, bfad_hcb_comp, &fcomp); spin_unlock_irqrestore(&bfad->bfad_lock, flags); - if (rc != BFA_STATUS_OK) + if (rc != BFA_STATUS_OK) { + kfree(fcstats); return NULL; + } wait_for_completion(&fcomp.comp); |