diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2019-04-30 19:34:08 +0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-12-10 18:01:33 +0000 |
| commit | 77251fec285eebe2258e81e643820428b92a68a6 (patch) | |
| tree | ec69bee8981504378c3c16417e40fabfe7b29b16 | |
| parent | 1551894964c90588b285d3a4f7da516e0ee9025a (diff) | |
| download | linux-77251fec285eebe2258e81e643820428b92a68a6.tar.gz linux-77251fec285eebe2258e81e643820428b92a68a6.tar.bz2 linux-77251fec285eebe2258e81e643820428b92a68a6.zip | |
appletalk: Set error code if register_snap_client failed
commit c93ad1337ad06a718890a89cdd85188ff9a5a5cc upstream.
If register_snap_client fails in atalk_init,
error code should be set, otherwise it will
triggers NULL pointer dereference while unloading
module.
Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | net/appletalk/ddp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 24bedf50c153..c91946ef2180 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1928,6 +1928,7 @@ static int __init atalk_init(void) ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv); if (!ddp_dl) { pr_crit("Unable to register DDP with SNAP.\n"); + rc = -ENOMEM; goto out_sock; } |