diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2018-11-07 22:36:23 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-22 07:32:48 +0100 |
| commit | f1dbaa10a0ec858cfe538d6dd1d40f7314563292 (patch) | |
| tree | adc94702743e3c39bd52d1928eef3d020c432bfc | |
| parent | 2af2a0030f1cda2c152a9ef1d24b39f158e1a61a (diff) | |
| download | linux-f1dbaa10a0ec858cfe538d6dd1d40f7314563292.tar.gz linux-f1dbaa10a0ec858cfe538d6dd1d40f7314563292.tar.bz2 linux-f1dbaa10a0ec858cfe538d6dd1d40f7314563292.zip | |
ext4: fix buffer leak in __ext4_read_dirblock() on error path
commit de59fae0043f07de5d25e02ca360f7d57bfa5866 upstream.
Fixes: dc6982ff4db1 ("ext4: refactor code to read directory blocks ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 3.9
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/ext4/namei.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index cb1bbbbb20e6..08980dd9b387 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -122,6 +122,7 @@ static struct buffer_head *__ext4_read_dirblock(struct inode *inode, if (!is_dx_block && type == INDEX) { ext4_error_inode(inode, __func__, line, block, "directory leaf block found instead of index block"); + brelse(bh); return ERR_PTR(-EIO); } if (!ext4_has_metadata_csum(inode->i_sb) || |