diff options
| author | Kangjie Lu <kjlu@umn.edu> | 2019-03-14 23:04:14 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-04-27 09:30:27 +0200 |
| commit | e3de185c7f2ff8ab4114152569bd4e9c20f3e314 (patch) | |
| tree | 2d16df45b1b91140052c92b6bcde58933ba0d5d0 | |
| parent | 77eed592753f0e97998636a18af823926126ab9e (diff) | |
| download | linux-e3de185c7f2ff8ab4114152569bd4e9c20f3e314.tar.gz linux-e3de185c7f2ff8ab4114152569bd4e9c20f3e314.tar.bz2 linux-e3de185c7f2ff8ab4114152569bd4e9c20f3e314.zip | |
ALSA: sb8: add a check for request_region
[ Upstream commit dcd0feac9bab901d5739de51b3f69840851f8919 ]
In case request_region fails, the fix returns an error code to
avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | sound/isa/sb/sb8.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index 6c32b3aa34af..938262d3aa7b 100644 --- a/sound/isa/sb/sb8.c +++ b/sound/isa/sb/sb8.c @@ -111,6 +111,10 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev) /* block the 0x388 port to avoid PnP conflicts */ acard->fm_res = request_region(0x388, 4, "SoundBlaster FM"); + if (!acard->fm_res) { + err = -EBUSY; + goto _err; + } if (port[dev] != SNDRV_AUTO_PORT) { if ((err = snd_sbdsp_create(card, port[dev], irq[dev], |