diff options
| author | Steve Wise <swise@opengridcomputing.com> | 2017-02-21 11:21:57 -0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2017-06-05 21:13:50 +0100 |
| commit | 90f2c353652782149589cb23c6cc6603c6c55611 (patch) | |
| tree | 9ff9077dfeab9aa04c46caf07144420ef0337209 | |
| parent | 0ac694d9a0348c1698973a03946565e0debd137e (diff) | |
| download | linux-90f2c353652782149589cb23c6cc6603c6c55611.tar.gz linux-90f2c353652782149589cb23c6cc6603c6c55611.tar.bz2 linux-90f2c353652782149589cb23c6cc6603c6c55611.zip | |
rdma_cm: fail iwarp accepts w/o connection params
commit f2625f7db4dd0bbd16a9c7d2950e7621f9aa57ad upstream.
cma_accept_iw() needs to return an error if conn_params is NULL.
Since this is coming from user space, we can crash.
Reported-by: Shaobo He <shaobo@cs.utah.edu>
Acked-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/infiniband/core/cma.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index d0d4aa9f4802..09cc0fc7d423 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -2737,6 +2737,9 @@ static int cma_accept_iw(struct rdma_id_private *id_priv, struct iw_cm_conn_param iw_param; int ret; + if (!conn_param) + return -EINVAL; + ret = cma_modify_qp_rtr(id_priv, conn_param); if (ret) return ret; |