diff options
| author | Johan Hovold <johan@kernel.org> | 2017-03-06 17:36:38 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-18 19:18:42 +0800 |
| commit | cc6ba470ebf84af1898dc305b307b0564c3963e6 (patch) | |
| tree | c5c71005f1163c7ca25a8eb67dd10963987fd1e6 | |
| parent | dc944b117e6c84ca95449bbbab089dfa07d703e6 (diff) | |
| download | linux-cc6ba470ebf84af1898dc305b307b0564c3963e6.tar.gz linux-cc6ba470ebf84af1898dc305b307b0564c3963e6.tar.bz2 linux-cc6ba470ebf84af1898dc305b307b0564c3963e6.zip | |
USB: serial: omninet: fix reference leaks at open
commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream.
This driver needlessly took another reference to the tty on open, a
reference which was then never released on close. This lead to not just
a leak of the tty, but also a driver reference leak that prevented the
driver from being unloaded after a port had once been opened.
Fixes: 4a90f09b20f4 ("tty: usb-serial krefs")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/serial/omninet.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c index a180b17d2432..76564b3bebb9 100644 --- a/drivers/usb/serial/omninet.c +++ b/drivers/usb/serial/omninet.c @@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port) static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port) { - struct usb_serial *serial = port->serial; - struct usb_serial_port *wport; - - wport = serial->port[1]; - tty_port_tty_set(&wport->port, tty); - return usb_serial_generic_open(tty, port); } |