diff options
| author | Konstantin Khlebnikov <khlebnikov@yandex-team.ru> | 2017-11-01 16:32:15 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-11-24 08:35:55 +0100 |
| commit | fda29ee84637310f3eab1d867062388015afd122 (patch) | |
| tree | 7af2790c03813851d42726f053d359ee9399846a | |
| parent | e5dc37a098176b75c646baaef2abba15e722d530 (diff) | |
| download | linux-fda29ee84637310f3eab1d867062388015afd122.tar.gz linux-fda29ee84637310f3eab1d867062388015afd122.tar.bz2 linux-fda29ee84637310f3eab1d867062388015afd122.zip | |
tcp_nv: fix division by zero in tcpnv_acked()
[ Upstream commit 4eebff27ca4182bbf5f039dd60d79e2d7c0a707e ]
Average RTT could become zero. This happened in real life at least twice.
This patch treats zero as 1us.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: Lawrence Brakmo <Brakmo@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/ipv4/tcp_nv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c index 6d650ed3cb59..5c871666c561 100644 --- a/net/ipv4/tcp_nv.c +++ b/net/ipv4/tcp_nv.c @@ -263,7 +263,7 @@ static void tcpnv_acked(struct sock *sk, const struct ack_sample *sample) /* rate in 100's bits per second */ rate64 = ((u64)sample->in_flight) * 8000000; - rate = (u32)div64_u64(rate64, (u64)(avg_rtt * 100)); + rate = (u32)div64_u64(rate64, (u64)(avg_rtt ?: 1) * 100); /* Remember the maximum rate seen during this RTT * Note: It may be more than one RTT. This function should be |