diff options
| author | Dexuan Cui <decui@microsoft.com> | 2017-09-21 23:41:47 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-10-12 11:56:15 +0200 |
| commit | c8b235ab6a3d2818440537cb813cc10af540d28e (patch) | |
| tree | 92f689c46c2908867bea1ee512a18aabcf60c443 | |
| parent | eb5c1df09af8fd96480799b532e2c31eecfb5203 (diff) | |
| download | linux-c8b235ab6a3d2818440537cb813cc10af540d28e.tar.gz linux-c8b235ab6a3d2818440537cb813cc10af540d28e.tar.bz2 linux-c8b235ab6a3d2818440537cb813cc10af540d28e.zip | |
vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister()
commit 33c150c2ee4a65a59190a124b45d05b1abf9478e upstream.
Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"),
we need this patch to resolve the below deadlock:
after we get the mutex in vmbus_hvsock_device_unregister() and call
vmbus_device_unregister() -> device_unregister() -> ... -> device_release()
-> vmbus_device_release(), we'll get a deadlock, because
vmbus_device_release() tries to get the same mutex.
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/hv/channel_mgmt.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 4bbb8dea4727..037361158074 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -922,14 +922,10 @@ static void vmbus_onoffer_rescind(struct vmbus_channel_message_header *hdr) void vmbus_hvsock_device_unregister(struct vmbus_channel *channel) { - mutex_lock(&vmbus_connection.channel_mutex); - BUG_ON(!is_hvsock_channel(channel)); channel->rescind = true; vmbus_device_unregister(channel->device_obj); - - mutex_unlock(&vmbus_connection.channel_mutex); } EXPORT_SYMBOL_GPL(vmbus_hvsock_device_unregister); |