diff options
| author | Aditya Pakki <pakki001@umn.edu> | 2019-03-20 10:42:32 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-04 09:15:20 +0200 |
| commit | d1e7cfba1e8952b4d7f03d7acb14822c29f743e5 (patch) | |
| tree | 7aa38a4167143af37ceba5dc4152278539d5c382 | |
| parent | 9db1d06bd4ada8ffd0605cc31daca8f410aa7548 (diff) | |
| download | linux-d1e7cfba1e8952b4d7f03d7acb14822c29f743e5.tar.gz linux-d1e7cfba1e8952b4d7f03d7acb14822c29f743e5.tar.bz2 linux-d1e7cfba1e8952b4d7f03d7acb14822c29f743e5.zip | |
staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc
[ Upstream commit 6a8ca24590a2136921439b376c926c11a6effc0e ]
phydm.internal is allocated using kzalloc which is used multiple
times without a check for NULL pointer. This patch avoids such a
scenario by returning 0, consistent with the failure case.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
| -rw-r--r-- | drivers/staging/rtlwifi/phydm/rtl_phydm.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/rtlwifi/phydm/rtl_phydm.c b/drivers/staging/rtlwifi/phydm/rtl_phydm.c index 85e490d3601f..cab563fefc34 100644 --- a/drivers/staging/rtlwifi/phydm/rtl_phydm.c +++ b/drivers/staging/rtlwifi/phydm/rtl_phydm.c @@ -191,6 +191,8 @@ static int rtl_phydm_init_priv(struct rtl_priv *rtlpriv, rtlpriv->phydm.internal = kzalloc(sizeof(struct phy_dm_struct), GFP_KERNEL); + if (!rtlpriv->phydm.internal) + return 0; _rtl_phydm_init_com_info(rtlpriv, ic, params); |