diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-10-09 12:01:47 -0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-09 10:17:58 +0100 |
| commit | 2d7c27957cac081eeacea7c38d8c9c59049883dc (patch) | |
| tree | 91a3992a7c381186c569e6d56aa5875b24a3c91c | |
| parent | 0902316524bf0d0e6de17263f9e02a3dd4e1d0ae (diff) | |
| download | linux-2d7c27957cac081eeacea7c38d8c9c59049883dc.tar.gz linux-2d7c27957cac081eeacea7c38d8c9c59049883dc.tar.bz2 linux-2d7c27957cac081eeacea7c38d8c9c59049883dc.zip | |
media: usb: fix memory leak in af9005_identify_state
commit 2289adbfa559050d2a38bcd9caac1c18b800e928 upstream.
In af9005_identify_state when returning -EIO the allocated buffer should
be released. Replace the "return -EIO" with assignment into ret and move
deb_info() under a check.
Fixes: af4e067e1dcf ("V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/media/usb/dvb-usb/af9005.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/media/usb/dvb-usb/af9005.c b/drivers/media/usb/dvb-usb/af9005.c index 986763b1b2b3..c047a0bdf91f 100644 --- a/drivers/media/usb/dvb-usb/af9005.c +++ b/drivers/media/usb/dvb-usb/af9005.c @@ -985,8 +985,9 @@ static int af9005_identify_state(struct usb_device *udev, else if (reply == 0x02) *cold = 0; else - return -EIO; - deb_info("Identify state cold = %d\n", *cold); + ret = -EIO; + if (!ret) + deb_info("Identify state cold = %d\n", *cold); err: kfree(buf); |