diff options
| author | Xiaoke Wang <xkernel.wang@foxmail.com> | 2021-12-13 15:39:31 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-12-29 12:17:35 +0100 |
| commit | c016618c6843c2c7265ae06d0490a98db22d27f9 (patch) | |
| tree | 99cf90c1e008e1968bc5ddb130ec98fe781a7062 | |
| parent | 7e13a3b81ffa158993d25ffb55ca94d96fa2cd42 (diff) | |
| download | linux-c016618c6843c2c7265ae06d0490a98db22d27f9.tar.gz linux-c016618c6843c2c7265ae06d0490a98db22d27f9.tar.bz2 linux-c016618c6843c2c7265ae06d0490a98db22d27f9.zip | |
ALSA: jack: Check the return value of kstrdup()
commit c01c1db1dc632edafb0dff32d40daf4f9c1a4e19 upstream.
kstrdup() can return NULL, it is better to check the return value of it.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/tencent_094816F3522E0DC704056C789352EBBF0606@qq.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | sound/core/jack.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/core/jack.c b/sound/core/jack.c index f652e90efd7e..5ddf81f091fa 100644 --- a/sound/core/jack.c +++ b/sound/core/jack.c @@ -234,6 +234,10 @@ int snd_jack_new(struct snd_card *card, const char *id, int type, return -ENOMEM; jack->id = kstrdup(id, GFP_KERNEL); + if (jack->id == NULL) { + kfree(jack); + return -ENOMEM; + } /* don't creat input device for phantom jack */ if (!phantom_jack) { |