summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShreeya Patel <shreeya.patel@collabora.com>2022-08-26 17:53:52 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-11-03 23:50:53 +0900
commit0acf3be1b826dc0de25394a84b2adfc4a83e148d (patch)
tree66d7ac4456f89781fb149d549359e58aab9428cd
parentb6749c3dae8b3fa0fb7ca98e8a7edb7f06c1509a (diff)
downloadlinux-0acf3be1b826dc0de25394a84b2adfc4a83e148d.tar.gz
linux-0acf3be1b826dc0de25394a84b2adfc4a83e148d.tar.bz2
linux-0acf3be1b826dc0de25394a84b2adfc4a83e148d.zip
iio: light: tsl2583: Fix module unloading
commit 0dec4d2f2636b9e54d9d29f17afc7687c5407f78 upstream. tsl2583 probe() uses devm_iio_device_register() and calling iio_device_unregister() causes the unregister to occur twice. s Switch to iio_device_register() instead of devm_iio_device_register() in probe to avoid the device managed cleanup. Fixes: 371894f5d1a0 ("iio: tsl2583: add runtime power management support") Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com> Link: https://lore.kernel.org/r/20220826122352.288438-1-shreeya.patel@collabora.com Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/iio/light/tsl2583.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
index 87ed9adec7e1..e13917602704 100644
--- a/drivers/iio/light/tsl2583.c
+++ b/drivers/iio/light/tsl2583.c
@@ -867,7 +867,7 @@ static int tsl2583_probe(struct i2c_client *clientp,
TSL2583_POWER_OFF_DELAY_MS);
pm_runtime_use_autosuspend(&clientp->dev);
- ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
+ ret = iio_device_register(indio_dev);
if (ret) {
dev_err(&clientp->dev, "%s: iio registration failed\n",
__func__);