diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-03 18:02:44 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-25 11:49:16 +0200 |
| commit | 2a598da14856ead80c726b38ba426c68637d9211 (patch) | |
| tree | 03c2c0864492cb01d57bfbd44789e1fd8dc3ef61 | |
| parent | 84e6d0af87e27bbc0db94f2e7323b34abe17b6e5 (diff) | |
| download | linux-2a598da14856ead80c726b38ba426c68637d9211.tar.gz linux-2a598da14856ead80c726b38ba426c68637d9211.tar.bz2 linux-2a598da14856ead80c726b38ba426c68637d9211.zip | |
usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe
commit 4757c9ade34178b351580133771f510b5ffcf9c8 upstream.
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() will check NULL pointer.
Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx")
Cc: stable <stable@kernel.org>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603140246.64529-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/gadget/udc/lpc32xx_udc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index cf56819f16e4..f7735d5ac6be 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -3021,6 +3021,7 @@ static int lpc32xx_udc_probe(struct platform_device *pdev) } udc->isp1301_i2c_client = isp1301_get_client(isp1301_node); + of_node_put(isp1301_node); if (!udc->isp1301_i2c_client) { retval = -EPROBE_DEFER; goto phy_fail; |