diff options
| author | Vamsi Krishna Brahmajosyula <vbrahmajosyula@vmware.com> | 2023-08-26 06:50:56 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-08-30 16:31:56 +0200 |
| commit | 058a52e061c535a58269c57c4229eacafbdf7de1 (patch) | |
| tree | 21783bbf9e60b0cfd869279a5560aee2428a1c4b | |
| parent | 84d90fb72a053c034b018fcc3cfaa6f606faf1c6 (diff) | |
| download | linux-058a52e061c535a58269c57c4229eacafbdf7de1.tar.gz linux-058a52e061c535a58269c57c4229eacafbdf7de1.tar.bz2 linux-058a52e061c535a58269c57c4229eacafbdf7de1.zip | |
netfilter: nf_queue: fix socket leak
Removal of the sock_hold got lost when backporting commit c3873070247d
("netfilter: nf_queue: fix possible use-after-free") to 4.19
Fixes: 34dc4a6a7f26 ("netfilter: nf_queue: fix possible use-after-free") in 4.19
Fixed in 4.14 with
https://lore.kernel.org/all/20221024112958.115275475@linuxfoundation.org/
Signed-off-by: Vimal Agrawal <vimal.agrawal@sophos.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
[vbrahmajosyula: The fix to the backport was missed in 4.19]
Signed-off-by: Vamsi Krishna Brahmajosyula <vbrahmajosyula@vmware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/netfilter/nf_queue.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c index 84c59de27882..b3a0385290a1 100644 --- a/net/netfilter/nf_queue.c +++ b/net/netfilter/nf_queue.c @@ -93,8 +93,6 @@ bool nf_queue_entry_get_refs(struct nf_queue_entry *entry) dev_hold(state->in); if (state->out) dev_hold(state->out); - if (state->sk) - sock_hold(state->sk); #if IS_ENABLED(CONFIG_BRIDGE_NETFILTER) if (entry->skb->nf_bridge) { struct net_device *physdev; |