summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2023-09-14 23:08:44 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-10-10 21:44:59 +0200
commit602f3633d9043762625b7d0c718823e0607b023e (patch)
treeb7e4302e27b4914205ae5848c5c9ab15541448c9
parent0994f3e464ff05793438d6f20c5658fc9bc22054 (diff)
downloadlinux-602f3633d9043762625b7d0c718823e0607b023e.tar.gz
linux-602f3633d9043762625b7d0c718823e0607b023e.tar.bz2
linux-602f3633d9043762625b7d0c718823e0607b023e.zip
i2c: i801: unregister tco_pdev in i801_probe() error path
commit 3914784553f68c931fc666dbe7e86fe881aada38 upstream. We have to unregister tco_pdev also if i2c_add_adapter() fails. Fixes: 9424693035a5 ("i2c: i801: Create iTCO device on newer Intel PCHs") Cc: stable@vger.kernel.org Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Reviewed-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Wolfram Sang <wsa@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/i2c/busses/i2c-i801.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index fb0ddaad87d2..6017f6aeee89 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1679,6 +1679,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
"SMBus I801 adapter at %04lx", priv->smba);
err = i2c_add_adapter(&priv->adapter);
if (err) {
+ platform_device_unregister(priv->tco_pdev);
i801_acpi_remove(priv);
return err;
}