diff options
| author | Ma Ke <make_ruc2021@163.com> | 2023-09-18 10:40:59 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-10-25 11:16:55 +0200 |
| commit | a9856853173eb074ba9038c9da94f173e45e9564 (patch) | |
| tree | 9410211b8a87376ed1c012485f5ed90770c53014 | |
| parent | 79700b56f17ddc28ca9f2b4c63d8dca288754897 (diff) | |
| download | linux-a9856853173eb074ba9038c9da94f173e45e9564.tar.gz linux-a9856853173eb074ba9038c9da94f173e45e9564.tar.bz2 linux-a9856853173eb074ba9038c9da94f173e45e9564.zip | |
HID: holtek: fix slab-out-of-bounds Write in holtek_kbd_input_event
[ Upstream commit ffe3b7837a2bb421df84d0177481db9f52c93a71 ]
There is a slab-out-of-bounds Write bug in hid-holtek-kbd driver.
The problem is the driver assumes the device must have an input
but some malicious devices violate this assumption.
Fix this by checking hid_device's input is non-empty before its usage.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/hid/hid-holtek-kbd.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/hid/hid-holtek-kbd.c b/drivers/hid/hid-holtek-kbd.c index 2f8eb6639744..72788ca260e0 100644 --- a/drivers/hid/hid-holtek-kbd.c +++ b/drivers/hid/hid-holtek-kbd.c @@ -133,6 +133,10 @@ static int holtek_kbd_input_event(struct input_dev *dev, unsigned int type, return -ENODEV; boot_hid = usb_get_intfdata(boot_interface); + if (list_empty(&boot_hid->inputs)) { + hid_err(hid, "no inputs found\n"); + return -ENODEV; + } boot_hid_input = list_first_entry(&boot_hid->inputs, struct hid_input, list); |