diff options
| author | Daniel Thompson <daniel.thompson@linaro.org> | 2024-02-20 15:35:24 +0000 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2024-03-26 18:22:41 -0400 |
| commit | ba9f50fa0edd4d45bc9840ba05efa9b526a30b53 (patch) | |
| tree | 26f81ed8a51a16b9a400b505ca342dedc978113f | |
| parent | 85360e411bd2239ef184178352fab6582a0fcb85 (diff) | |
| download | linux-ba9f50fa0edd4d45bc9840ba05efa9b526a30b53.tar.gz linux-ba9f50fa0edd4d45bc9840ba05efa9b526a30b53.tar.bz2 linux-ba9f50fa0edd4d45bc9840ba05efa9b526a30b53.zip | |
backlight: da9052: Fully initialize backlight_properties during probe
[ Upstream commit 0285e9efaee8276305db5c52a59baf84e9731556 ]
props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!
Fixes: 6ede3d832aaa ("backlight: add driver for DA9052/53 PMIC v1")
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240220153532.76613-2-daniel.thompson@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/video/backlight/da9052_bl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c index 49035c12739a..d48513eb3bc5 100644 --- a/drivers/video/backlight/da9052_bl.c +++ b/drivers/video/backlight/da9052_bl.c @@ -122,6 +122,7 @@ static int da9052_backlight_probe(struct platform_device *pdev) wleds->led_reg = platform_get_device_id(pdev)->driver_data; wleds->state = DA9052_WLEDS_OFF; + memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_RAW; props.max_brightness = DA9052_MAX_BRIGHTNESS; |