diff options
| author | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> | 2019-08-15 23:56:35 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-09-21 07:16:57 +0200 |
| commit | 30881d79de31b2b4010c309ca9e28e9ebb446081 (patch) | |
| tree | 35456587317658c2881226ac3180a7dadaf1e4b1 | |
| parent | 55ed0ad50201c8ee196d6c423e94eadec8a76007 (diff) | |
| download | linux-30881d79de31b2b4010c309ca9e28e9ebb446081.tar.gz linux-30881d79de31b2b4010c309ca9e28e9ebb446081.tar.bz2 linux-30881d79de31b2b4010c309ca9e28e9ebb446081.zip | |
xdp: unpin xdp umem pages in error path
[ Upstream commit fb89c39455e4b49881c5a42761bd71f03d3ef888 ]
Fix mem leak caused by missed unpin routine for umem pages.
Fixes: 8aef7340ae9695 ("xsk: introduce xdp_umem_page")
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | net/xdp/xdp_umem.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c index a3b037fbfecd..8cab91c482ff 100644 --- a/net/xdp/xdp_umem.c +++ b/net/xdp/xdp_umem.c @@ -322,7 +322,7 @@ static int xdp_umem_reg(struct xdp_umem *umem, struct xdp_umem_reg *mr) umem->pages = kcalloc(umem->npgs, sizeof(*umem->pages), GFP_KERNEL); if (!umem->pages) { err = -ENOMEM; - goto out_account; + goto out_pin; } for (i = 0; i < umem->npgs; i++) @@ -330,6 +330,8 @@ static int xdp_umem_reg(struct xdp_umem *umem, struct xdp_umem_reg *mr) return 0; +out_pin: + xdp_umem_unpin_pages(umem); out_account: xdp_umem_unaccount_pages(umem); return err; |