diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-01-14 18:16:04 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-05 13:03:32 +0000 |
| commit | e5a7333b9140582d4cb9eccb995445f4845610bc (patch) | |
| tree | 0c7ddb8d865ea1c28ca9396e9d2aef87364e6d0e | |
| parent | 917c8fe39f4d42c3850b22d6a0bf3ffab1466d19 (diff) | |
| download | linux-e5a7333b9140582d4cb9eccb995445f4845610bc.tar.gz linux-e5a7333b9140582d4cb9eccb995445f4845610bc.tar.bz2 linux-e5a7333b9140582d4cb9eccb995445f4845610bc.zip | |
staging: wlan-ng: ensure error return is actually returned
commit 4cc41cbce536876678b35e03c4a8a7bb72c78fa9 upstream.
Currently when the call to prism2sta_ifst fails a netdev_err error
is reported, error return variable result is set to -1 but the
function always returns 0 for success. Fix this by returning
the error value in variable result rather than 0.
Addresses-Coverity: ("Unused value")
Fixes: 00b3ed168508 ("Staging: add wlan-ng prism2 usb driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200114181604.390235-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/wlan-ng/prism2mgmt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index c1ad0aea23b9..73ec8d3936d5 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -940,7 +940,7 @@ int prism2mgmt_flashdl_state(wlandevice_t *wlandev, void *msgp) } } - return 0; + return result; } /*---------------------------------------------------------------- |