diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> | 2021-03-13 18:29:49 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-17 16:10:18 +0100 |
| commit | 9c8c498ae28e116f26509d72d0db667eb5414dac (patch) | |
| tree | b843e4097823337ab211fabcc7bd845e07a23aab | |
| parent | 2a667b9a2ee4c6d3ebe028e4b594a5eaad5d0abd (diff) | |
| download | linux-9c8c498ae28e116f26509d72d0db667eb5414dac.tar.gz linux-9c8c498ae28e116f26509d72d0db667eb5414dac.tar.bz2 linux-9c8c498ae28e116f26509d72d0db667eb5414dac.zip | |
iio: imu: adis16400: release allocated memory on failure
From: Navid Emamdoost <navid.emamdoost@gmail.com>
commit ab612b1daf415b62c58e130cb3d0f30b255a14d0 upstream.
In adis_update_scan_mode, if allocation for adis->buffer fails,
previously allocated adis->xfer needs to be released.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/iio/imu/adis_buffer.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c index 36607d52fee0..9de553e8c214 100644 --- a/drivers/iio/imu/adis_buffer.c +++ b/drivers/iio/imu/adis_buffer.c @@ -39,8 +39,11 @@ int adis_update_scan_mode(struct iio_dev *indio_dev, return -ENOMEM; adis->buffer = kzalloc(indio_dev->scan_bytes * 2, GFP_KERNEL); - if (!adis->buffer) + if (!adis->buffer) { + kfree(adis->xfer); + adis->xfer = NULL; return -ENOMEM; + } rx = adis->buffer; tx = rx + scan_count; |