summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLucas Stankus <lucas.p.stankus@gmail.com>2021-05-11 17:54:18 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-06-03 08:23:29 +0200
commit3cd5f508273992c9ce48d0e5d432e2454161d615 (patch)
treedf3a44e4df25d90571a622249a2fb56a282af3a5
parent8fff0b5324e64f4840e092d108c1383d76454d0c (diff)
downloadlinux-3cd5f508273992c9ce48d0e5d432e2454161d615.tar.gz
linux-3cd5f508273992c9ce48d0e5d432e2454161d615.tar.bz2
linux-3cd5f508273992c9ce48d0e5d432e2454161d615.zip
staging: iio: cdc: ad7746: avoid overwrite of num_channels
commit 04f5b9f539ce314f758d919a14dc7a669f3b7838 upstream. AD7745 devices don't have the CIN2 pins and therefore can't handle related channels. Forcing the number of AD7746 channels may lead to enabling more channels than what the hardware actually supports. Avoid num_channels being overwritten after first assignment. Signed-off-by: Lucas Stankus <lucas.p.stankus@gmail.com> Fixes: 83e416f458d53 ("staging: iio: adc: Replace, rewrite ad7745 from scratch.") Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: <Stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/iio/cdc/ad7746.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 5771d4ee8ef1..1a71bca4e698 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -714,7 +714,6 @@ static int ad7746_probe(struct i2c_client *client,
indio_dev->num_channels = ARRAY_SIZE(ad7746_channels);
else
indio_dev->num_channels = ARRAY_SIZE(ad7746_channels) - 2;
- indio_dev->num_channels = ARRAY_SIZE(ad7746_channels);
indio_dev->modes = INDIO_DIRECT_MODE;
if (pdata) {