summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWang ShaoBo <bobo.shaobowang@huawei.com>2022-11-10 19:38:23 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-11-25 17:35:39 +0100
commit44658d65f6b3118f595a1229d7eed74845a5e2ac (patch)
treefc088673036273542f945978b219a65264704ab7
parentbbd53d05c4c892080ef3b617eff4f57903acecb9 (diff)
downloadlinux-44658d65f6b3118f595a1229d7eed74845a5e2ac.tar.gz
linux-44658d65f6b3118f595a1229d7eed74845a5e2ac.tar.bz2
linux-44658d65f6b3118f595a1229d7eed74845a5e2ac.zip
mISDN: fix misuse of put_device() in mISDN_register_device()
[ Upstream commit 2d25107e111a85c56f601a5470f1780ec054e6ac ] We should not release reference by put_device() before calling device_initialize(). Fixes: e7d1d4d9ac0d ("mISDN: fix possible memory leak in mISDN_register_device()") Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/isdn/mISDN/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c
index 5cd53b2c47c7..e542439f4950 100644
--- a/drivers/isdn/mISDN/core.c
+++ b/drivers/isdn/mISDN/core.c
@@ -231,7 +231,7 @@ mISDN_register_device(struct mISDNdevice *dev,
err = get_free_devid();
if (err < 0)
- goto error1;
+ return err;
dev->id = err;
device_initialize(&dev->dev);