summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Fertic <jeremyfertic@gmail.com>2018-12-11 17:55:00 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-08 07:22:56 +0200
commit9f929fd72c8d622e2ae8e0cde1b98228a38b65b7 (patch)
tree139ba24338d20ac4f16795b0c756d9d7fa53de44
parent08b450e6826c27e4c6cc7cf158ff9f930182711c (diff)
downloadlinux-9f929fd72c8d622e2ae8e0cde1b98228a38b65b7.tar.gz
linux-9f929fd72c8d622e2ae8e0cde1b98228a38b65b7.tar.bz2
linux-9f929fd72c8d622e2ae8e0cde1b98228a38b65b7.zip
staging: iio: adt7316: allow adt751x to use internal vref for all dacs
commit 10bfe7cc1739c22f0aa296b39e53f61e9e3f4d99 upstream. With adt7516/7/9, internal vref is available for dacs a and b, dacs c and d, or all dacs. The driver doesn't currently support internal vref for all dacs. Change the else if to an if so both bits are checked rather than just one or the other. Signed-off-by: Jeremy Fertic <jeremyfertic@gmail.com> Fixes: 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9 driver") Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/iio/addac/adt7316.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 7839d869d25d..f85a7a550728 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -1079,7 +1079,7 @@ static ssize_t adt7316_store_DAC_internal_Vref(struct device *dev,
ldac_config = chip->ldac_config & (~ADT7516_DAC_IN_VREF_MASK);
if (data & 0x1)
ldac_config |= ADT7516_DAC_AB_IN_VREF;
- else if (data & 0x2)
+ if (data & 0x2)
ldac_config |= ADT7516_DAC_CD_IN_VREF;
} else {
ret = kstrtou8(buf, 16, &data);