diff options
| author | Haibo Chen <haibo.chen@nxp.com> | 2022-04-25 16:41:00 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-29 08:59:50 +0200 |
| commit | 58c3a27e9c233bcb203624ce4f4132423fe3318d (patch) | |
| tree | e6d0d85002b520d4d650be397fbb376b29a3d2e8 | |
| parent | 5ee016f6120ae6c64f9f8953405590e6d4b604e1 (diff) | |
| download | linux-58c3a27e9c233bcb203624ce4f4132423fe3318d.tar.gz linux-58c3a27e9c233bcb203624ce4f4132423fe3318d.tar.bz2 linux-58c3a27e9c233bcb203624ce4f4132423fe3318d.zip | |
iio: mma8452: fix probe fail when device tree compatible is used.
[ Upstream commit fe18894930a025617114aa8ca0adbf94d5bffe89 ]
Correct the logic for the probe. First check of_match_table, if
not meet, then check i2c_driver.id_table. If both not meet, then
return fail.
Fixes: a47ac019e7e8 ("iio: mma8452: Fix probe failing when an i2c_device_id is used")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Link: https://lore.kernel.org/r/1650876060-17577-1-git-send-email-haibo.chen@nxp.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/iio/accel/mma8452.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index e7e280282774..67463be797de 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1542,11 +1542,13 @@ static int mma8452_probe(struct i2c_client *client, mutex_init(&data->lock); data->chip_info = device_get_match_data(&client->dev); - if (!data->chip_info && id) { - data->chip_info = &mma_chip_info_table[id->driver_data]; - } else { - dev_err(&client->dev, "unknown device model\n"); - return -ENODEV; + if (!data->chip_info) { + if (id) { + data->chip_info = &mma_chip_info_table[id->driver_data]; + } else { + dev_err(&client->dev, "unknown device model\n"); + return -ENODEV; + } } data->vdd_reg = devm_regulator_get(&client->dev, "vdd"); |