diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-07-21 22:40:54 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-08-25 11:38:17 +0200 |
| commit | f43a72d4da91a96f106122322df40b274a6b205d (patch) | |
| tree | 98741f447ff766ddf6565ae412b3d986e8254047 | |
| parent | b30aa4ff11a1f3431952d07ea0c4b18e94fc6011 (diff) | |
| download | linux-f43a72d4da91a96f106122322df40b274a6b205d.tar.gz linux-f43a72d4da91a96f106122322df40b274a6b205d.tar.bz2 linux-f43a72d4da91a96f106122322df40b274a6b205d.zip | |
dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed
[ Upstream commit 1e42f82cbec7b2cc4873751e7791e6611901c5fc ]
It's not allowed to quit remove early without cleaning up completely.
Otherwise this results in resource leaks that probably yield graver
problems later. Here for example some tasklets might survive the lifetime
of the sprd-dma device and access sdev which is freed after .remove()
returns.
As none of the device freeing requires an active device, just ignore the
return value of pm_runtime_get_sync().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
Link: https://lore.kernel.org/r/20220721204054.323602-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/dma/sprd-dma.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 4357d2395e6b..60115d8d4083 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -1236,11 +1236,8 @@ static int sprd_dma_remove(struct platform_device *pdev) { struct sprd_dma_dev *sdev = platform_get_drvdata(pdev); struct sprd_dma_chn *c, *cn; - int ret; - ret = pm_runtime_get_sync(&pdev->dev); - if (ret < 0) - return ret; + pm_runtime_get_sync(&pdev->dev); /* explicitly free the irq */ if (sdev->irq > 0) |