diff options
| author | Joel Stanley <joel@jms.id.au> | 2023-01-20 09:48:56 +1030 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-02-15 17:22:25 +0100 |
| commit | 61f8a493c0760883f73565d7a23af5a18f2077b2 (patch) | |
| tree | c1ae9ac8e0335a8fad7a23ae18089475545699f6 | |
| parent | ef3edede7b732395db145735bf4feaa960573995 (diff) | |
| download | linux-61f8a493c0760883f73565d7a23af5a18f2077b2.tar.gz linux-61f8a493c0760883f73565d7a23af5a18f2077b2.tar.bz2 linux-61f8a493c0760883f73565d7a23af5a18f2077b2.zip | |
pinctrl: aspeed: Fix confusing types in return value
[ Upstream commit 287a344a11f1ebd31055cf9b22c88d7005f108d7 ]
The function signature is int, but we return a bool. Instead return a
negative errno as the kerneldoc suggests.
Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs")
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Link: https://lore.kernel.org/r/20230119231856.52014-1-joel@jms.id.au
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index e792318c3894..d26d85954627 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -121,7 +121,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx, int ret = 0; if (!exprs) - return true; + return -EINVAL; while (*exprs && !ret) { ret = aspeed_sig_expr_disable(ctx, *exprs); |