summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@kernel.org>2021-05-25 11:28:40 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-07-31 08:13:46 +0200
commit3ba36f82d50da4af6f41fe23802ca860ae5278b7 (patch)
treeb7750943634f5ad4c58f4aa245320082fb177aa0
parent1dccf9d5a7245de250e7efb17776fca54bb1f74f (diff)
downloadlinux-3ba36f82d50da4af6f41fe23802ca860ae5278b7.tar.gz
linux-3ba36f82d50da4af6f41fe23802ca860ae5278b7.tar.bz2
linux-3ba36f82d50da4af6f41fe23802ca860ae5278b7.zip
rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader()
[ Upstream commit a9ab9cce9367a2cc02a3c7eb57a004dc0b8f380d ] Invoking trc_del_holdout() from within trc_wait_for_one_reader() is only a performance optimization because the RCU Tasks Trace grace-period kthread will eventually do this within check_all_holdout_tasks_trace(). But it is not a particularly important performance optimization because it only applies to the grace-period kthread, of which there is but one. This commit therefore removes this invocation of trc_del_holdout() in favor of the one in check_all_holdout_tasks_trace() in the grace-period kthread. Reported-by: "Xu, Yanfei" <yanfei.xu@windriver.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--kernel/rcu/tasks.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index 71e9d625371a..fcef5f0c60b8 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -937,7 +937,6 @@ static void trc_wait_for_one_reader(struct task_struct *t,
// The current task had better be in a quiescent state.
if (t == current) {
t->trc_reader_checked = true;
- trc_del_holdout(t);
WARN_ON_ONCE(t->trc_reader_nesting);
return;
}