diff options
| author | Wang Kefeng <wangkefeng.wang@huawei.com> | 2021-08-23 10:41:42 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-06 14:13:31 +0100 |
| commit | 57f31b313231d81639813eac0a3c2e21984bf557 (patch) | |
| tree | 5bb58bbb3bbc2d6476740be7c66d63c69e293c2a | |
| parent | 110d5f4421ed8276801a7e10257803d4e5f163e2 (diff) | |
| download | linux-57f31b313231d81639813eac0a3c2e21984bf557.tar.gz linux-57f31b313231d81639813eac0a3c2e21984bf557.tar.bz2 linux-57f31b313231d81639813eac0a3c2e21984bf557.zip | |
ARM: 9120/1: Revert "amba: make use of -1 IRQs warn"
commit eb4f756915875b0ea0757751cd29841f0504d547 upstream.
After commit 77a7300abad7 ("of/irq: Get rid of NO_IRQ usage"),
no irq case has been removed, irq_of_parse_and_map() will return
0 in all cases when get error from parse and map an interrupt into
linux virq space.
amba_device_register() is only used on no-DT initialization, see
s3c64xx_pl080_init() arch/arm/mach-s3c/pl080.c
ep93xx_init_devices() arch/arm/mach-ep93xx/core.c
They won't set -1 to irq[0], so no need the warn.
This reverts commit 2eac58d5026e4ec8b17ff8b62877fea9e1d2f1b3.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/amba/bus.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 962041148482..6c0f7f4f7d1d 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -377,9 +377,6 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent) void __iomem *tmp; int i, ret; - WARN_ON(dev->irq[0] == (unsigned int)-1); - WARN_ON(dev->irq[1] == (unsigned int)-1); - ret = request_resource(parent, &dev->res); if (ret) goto err_out; |