diff options
| author | Nilesh Javali <njavali@marvell.com> | 2023-06-07 17:08:39 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-07-23 13:47:57 +0200 |
| commit | 1ccd52b790a66b8b5f75c87eab8c3a37f941a2bf (patch) | |
| tree | 423867994131b65841a96bbfda1dcca5a414ca63 | |
| parent | 5a52a2e14fe866541bbc0033058e44bf0bf0c580 (diff) | |
| download | linux-1ccd52b790a66b8b5f75c87eab8c3a37f941a2bf.tar.gz linux-1ccd52b790a66b8b5f75c87eab8c3a37f941a2bf.tar.bz2 linux-1ccd52b790a66b8b5f75c87eab8c3a37f941a2bf.zip | |
scsi: qla2xxx: Check valid rport returned by fc_bsg_to_rport()
commit af73f23a27206ffb3c477cac75b5fcf03410556e upstream.
Klocwork reported warning of rport maybe NULL and will be dereferenced.
rport returned by call to fc_bsg_to_rport() could be NULL and dereferenced.
Check valid rport returned by fc_bsg_to_rport().
Cc: stable@vger.kernel.org
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230607113843.37185-5-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_bsg.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index c7c5c013a074..6c2ff0e8ba12 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -283,6 +283,10 @@ qla2x00_process_els(struct bsg_job *bsg_job) if (bsg_request->msgcode == FC_BSG_RPT_ELS) { rport = fc_bsg_to_rport(bsg_job); + if (!rport) { + rval = -ENOMEM; + goto done; + } fcport = *(fc_port_t **) rport->dd_data; host = rport_to_shost(rport); vha = shost_priv(host); |