diff options
| author | Wei Chen <harperchen1110@gmail.com> | 2023-08-10 08:23:33 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-08-30 16:18:18 +0200 |
| commit | 60ba1bfa036a84c5a8ddea7b104b5bde735ef066 (patch) | |
| tree | 3bd88ae292f53434c9b1d101e406f048240d186b | |
| parent | 544cd10defa1bf1acfe533f8a7d10e7a001e07b9 (diff) | |
| download | linux-60ba1bfa036a84c5a8ddea7b104b5bde735ef066.tar.gz linux-60ba1bfa036a84c5a8ddea7b104b5bde735ef066.tar.bz2 linux-60ba1bfa036a84c5a8ddea7b104b5bde735ef066.zip | |
media: vcodec: Fix potential array out-of-bounds in encoder queue_setup
commit e7f2e65699e2290fd547ec12a17008764e5d9620 upstream.
variable *nplanes is provided by user via system call argument. The
possible value of q_data->fmt->num_planes is 1-3, while the value
of *nplanes can be 1-8. The array access by index i can cause array
out-of-bounds.
Fix this bug by checking *nplanes against the array size.
Fixes: 4e855a6efa54 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver")
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c index d97a6765693f..389ac3d1f344 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c @@ -733,6 +733,8 @@ static int vb2ops_venc_queue_setup(struct vb2_queue *vq, return -EINVAL; if (*nplanes) { + if (*nplanes != q_data->fmt->num_planes) + return -EINVAL; for (i = 0; i < *nplanes; i++) if (sizes[i] < q_data->sizeimage[i]) return -EINVAL; |