diff options
| author | Su Hui <suhui@nfschina.com> | 2023-10-08 14:39:30 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-11-28 16:56:34 +0000 |
| commit | e4088d7d8f1123006d46a42edf51b8c960a58ef9 (patch) | |
| tree | 149532c38a6b99f81e16dd5dce69123b2754e689 | |
| parent | 12055238d04630e69c26b5a98ee805cdd0f1a26f (diff) | |
| download | linux-e4088d7d8f1123006d46a42edf51b8c960a58ef9.tar.gz linux-e4088d7d8f1123006d46a42edf51b8c960a58ef9.tar.bz2 linux-e4088d7d8f1123006d46a42edf51b8c960a58ef9.zip | |
f2fs: avoid format-overflow warning
commit e0d4e8acb3789c5a8651061fbab62ca24a45c063 upstream.
With gcc and W=1 option, there's a warning like this:
fs/f2fs/compress.c: In function ‘f2fs_init_page_array_cache’:
fs/f2fs/compress.c:1984:47: error: ‘%u’ directive writing between
1 and 7 bytes into a region of size between 5 and 8
[-Werror=format-overflow=]
1984 | sprintf(slab_name, "f2fs_page_array_entry-%u:%u", MAJOR(dev),
MINOR(dev));
| ^~
String "f2fs_page_array_entry-%u:%u" can up to 35. The first "%u" can up
to 4 and the second "%u" can up to 7, so total size is "24 + 4 + 7 = 35".
slab_name's size should be 35 rather than 32.
Cc: stable@vger.kernel.org
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/f2fs/compress.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index 455fac164fda..3982b4a7618c 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -1906,7 +1906,7 @@ void f2fs_destroy_compress_inode(struct f2fs_sb_info *sbi) int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi) { dev_t dev = sbi->sb->s_bdev->bd_dev; - char slab_name[32]; + char slab_name[35]; sprintf(slab_name, "f2fs_page_array_entry-%u:%u", MAJOR(dev), MINOR(dev)); |