diff options
| author | Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> | 2023-11-28 10:04:37 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-12-08 08:48:03 +0100 |
| commit | a4515a2f5b1e0a4f689f3f0412eb9272c3aaf9b3 (patch) | |
| tree | 72524e3f65e351219951aa20561958dc5024e3f9 | |
| parent | 2ba0a8330dae137646ab0d54bd816f90375df201 (diff) | |
| download | linux-a4515a2f5b1e0a4f689f3f0412eb9272c3aaf9b3.tar.gz linux-a4515a2f5b1e0a4f689f3f0412eb9272c3aaf9b3.tar.bz2 linux-a4515a2f5b1e0a4f689f3f0412eb9272c3aaf9b3.zip | |
net: ravb: Start TX queues after HW initialization succeeded
[ Upstream commit 6f32c086602050fc11157adeafaa1c1eb393f0af ]
ravb_phy_start() may fail. If that happens, the TX queues will remain
started. Thus, move the netif_tx_start_all_queues() after PHY is
successfully initialized.
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/renesas/ravb_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index a556faa47f03..0c73bc4df98d 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1448,13 +1448,13 @@ static int ravb_open(struct net_device *ndev) if (info->gptp) ravb_ptp_init(ndev, priv->pdev); - netif_tx_start_all_queues(ndev); - /* PHY control start */ error = ravb_phy_start(ndev); if (error) goto out_ptp_stop; + netif_tx_start_all_queues(ndev); + return 0; out_ptp_stop: |